Docs: add whatsnew for free-threading #118679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesbury
changed the title
DinoV
reviewed
May 7, 2024
ambv
approved these changes
May 7, 2024
Contributor
ambv
left a comment
ambv
left a comment
There was a problem hiding this comment.
LGTM but I'd add a bit of motivation to balance the flashing warning signs.
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
gvanrossum
reviewed
May 7, 2024
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Eventually I'd like to see more color about what extension modules should do to be built specially for the free-threaded build. (Not necessarily here, but maybe in a HOWTO doc or section of the Extending and Embedding docs linked from here.)
Comment on lines
+1071
to
+1074
| * Use :func:`!sys._is_gil_enabled` to determine if the :term:`GIL` is enabled. | ||
|
|
||
| * Use ``sysconfig.get_config_var("Py_GIL_DISABLED")`` to identify CPython | ||
| builds configured with ``--disable-gil``. |
Member
There was a problem hiding this comment.
It's not clear from this why we need both APIs. I'm guessing it's because even when built with --disable-gil the GIL may be dynamically re-enabled?
Contributor
Author
|
The extension HOWTO and further docs updates are definitely on the list of things to do, but will probably happen sometime after beta 1. |
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--118679.org.readthedocs.build/