gh-118598: Improve suggestion of TypeError when attempting to iterate over an integer#118602
Open
vladimirrotariu wants to merge 1 commit intopython:mainfrom
Open
gh-118598: Improve suggestion of TypeError when attempting to iterate over an integer#118602vladimirrotariu wants to merge 1 commit intopython:mainfrom
vladimirrotariu wants to merge 1 commit intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
terryjreedy
reviewed
May 5, 2024
| File "<pyshell#4>", line 1, in -toplevel- | ||
| (i for i in 6) | ||
| TypeError: 'int' object is not iterable | ||
| TypeError: 'int' object is not iterable. Did you mean: 'range('int')'? |
Member
There was a problem hiding this comment.
Single quotes within single quotes does not work. Just range(...) or range(<int>) would be better. Change would apply to other patches below.
hauntsaninja
reviewed
May 7, 2024
Contributor
There was a problem hiding this comment.
Note it looks like there isn't consensus on the issue about the best scope for this message.
Adding this to traceback.py based on substring checks also feels a little broad in my opinion, I'd prefer if error message was changed where it is raised.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding issue: #118598