gh-92123: Convert _elementtree types to heap types
#99221
Conversation
|
With #100689 the capsule also needs to isolated. LMK when this goes out of draft. |
Yes, I also made a note of that. I hope to be able to allocate time for CPython this weekend. |
|
I remember doing a proof-of-concept full isolation of
We might want to split the UDPATE This plan won't work out, because we need heap types before being able to completely get rid of
|
|
@kumaraditya303: I wonder if we should tie this PR to gh-92123, or if we should create a targeted issue specifically for isolating |
erlend-aasland
changed the title
_elementtree types to heap types
erlend-aasland
added
the
|
If you want to schedule another build, you need to add the |
bedevere-bot
removed
the
Let's link it to the bug report, we did a similar thing for I am in favor of landing this PR and continue other improvements in smaller PRs. |
erlend-aasland
changed the title
_elementtree types to heap types_elementtree types to heap types
|
@kumaraditya303: thanks for the immutable types reminder; I also had forgotten to disallow instantiation for the iter type. |
erlend-aasland
added
the
|
If you want to schedule another build, you need to add the |
bedevere-bot
removed
the
| } | ||
| } else { | ||
| return NULL; | ||
| goto error; | ||
| } | ||
|
|
||
| st->str_append = PyUnicode_InternFromString("append"); |
There was a problem hiding this comment.
Also change NULL checks like on line 4269 to goto error?
There was a problem hiding this comment.
Ah, that a result of a bad merge. Thanks!
There was a problem hiding this comment.
BTW, the interned strings are not freed in the module clear/free functions.
GH-23428 resurrected.