Skip to content

Promote sources in mime/multipart package#16183

Draft
owen-mc wants to merge 2 commits intogithub:mainfrom
owen-mc:go/promote-mime-multipart-sources
Draft

Promote sources in mime/multipart package#16183
owen-mc wants to merge 2 commits intogithub:mainfrom
owen-mc:go/promote-mime-multipart-sources

Conversation

@owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Apr 11, 2024

These were contributed by @am0o0 in #13553 .

@github-actions github-actions bot added the Go label Apr 11, 2024
@owen-mc owen-mc requested a review from atorralba April 11, 2024 11:28
@owen-mc owen-mc force-pushed the go/promote-mime-multipart-sources branch from da00120 to 9528c88 Compare April 19, 2024 15:37
@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2024

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

go

Generated file changes for go

  • Changes to framework-coverage-go.rst:
-    `Standard library <https://pkg.go.dev/std>`_,"````, ``archive/*``, ``bufio``, ``bytes``, ``cmp``, ``compress/*``, ``container/*``, ``context``, ``crypto``, ``crypto/*``, ``database/*``, ``debug/*``, ``embed``, ``encoding``, ``encoding/*``, ``errors``, ``expvar``, ``flag``, ``fmt``, ``go/*``, ``hash``, ``hash/*``, ``html``, ``html/*``, ``image``, ``image/*``, ``index/*``, ``io``, ``io/*``, ``log``, ``log/*``, ``maps``, ``math``, ``math/*``, ``mime``, ``mime/*``, ``net``, ``net/*``, ``os``, ``os/*``, ``path``, ``path/*``, ``plugin``, ``reflect``, ``reflect/*``, ``regexp``, ``regexp/*``, ``slices``, ``sort``, ``strconv``, ``strings``, ``sync``, ``sync/*``, ``syscall``, ``syscall/*``, ``testing``, ``testing/*``, ``text/*``, ``time``, ``time/*``, ``unicode``, ``unicode/*``, ``unsafe``",8,584,
+    `Standard library <https://pkg.go.dev/std>`_,"````, ``archive/*``, ``bufio``, ``bytes``, ``cmp``, ``compress/*``, ``container/*``, ``context``, ``crypto``, ``crypto/*``, ``database/*``, ``debug/*``, ``embed``, ``encoding``, ``encoding/*``, ``errors``, ``expvar``, ``flag``, ``fmt``, ``go/*``, ``hash``, ``hash/*``, ``html``, ``html/*``, ``image``, ``image/*``, ``index/*``, ``io``, ``io/*``, ``log``, ``log/*``, ``maps``, ``math``, ``math/*``, ``mime``, ``mime/*``, ``net``, ``net/*``, ``os``, ``os/*``, ``path``, ``path/*``, ``plugin``, ``reflect``, ``reflect/*``, ``regexp``, ``regexp/*``, ``slices``, ``sort``, ``strconv``, ``strings``, ``sync``, ``sync/*``, ``syscall``, ``syscall/*``, ``testing``, ``testing/*``, ``text/*``, ``time``, ``time/*``, ``unicode``, ``unicode/*``, ``unsafe``",12,584,
-    Totals,,20,877,24
+    Totals,,24,877,24
  • Changes to framework-coverage-go.csv:
- mime/multipart,,,8,,,,8,
+ mime/multipart,,4,8,,,4,8,

@owen-mc
Copy link
Contributor Author

owen-mc commented Apr 21, 2024

The test failures are due to model numbers changing. There is no point fixing them until this is ready to be merged, as they may change again if more models are merged.

@owen-mc owen-mc force-pushed the go/promote-mime-multipart-sources branch from 9528c88 to cbe161b Compare June 11, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant