gh-93592: Port regression test to main branch #96208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, didn't notice that a review had already been requested. no rush :) |
|
Thanks |
|
Thanks @kristjanvalur for the PR, and @markshannon for merging it |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 26, 2022
(cherry picked from commit 771eff2) Co-authored-by: Kristján Valur Jónsson <sweskman@gmail.com>
|
GH-96313 is a backport of this pull request to the 3.11 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
PR #95207 added fixes for 3.10 and earlier.
maindoesn't suffer from this issue due to code rewrite, but the regression test should still be added.