JS: More robust CommonJS/ES2015 detection logic for extractor #16061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notice the TRAP lines ``` is_module(#20001) is_es2015_module(#20001) ```
Should hopefully make it easier to review these changes to have it split into its' own commit :)
Created shared AbstractDetector to not duplicate all the tedious logic ;) I took inspiration from the tests in `javascript/extractor/tests/esnext/input/dynamic-import.js`
As I see it, these all seem to have invalid code initially anyway, but this is definitely something a JS expert should review :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
review commit-by-commit recommended.
These changes caused a few unrelated trap files to change as well, I think these are all for programs with syntax-errors, but would certainly like you to take a look at these @asgerf (see 60944a9)
I think the change-note for this need to go into the internal repo for the CLI.