New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: support Java 22 language features #16023
Open
smowton
wants to merge
23
commits into
github:main
Choose a base branch
from
smowton:smowton/feature/jdk22-support
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New language features supported (all described by https://openjdk.org/jeps/456):
TypeName _), which can occur in declarations and binding patterns._), which can occur in record-pattern context (e.g.MyRecord(int x, _))case A _, B _ when sharedGuard)case A _: case "Constant": case MyRecord(_):)Anonymous variables, lambda parameters and patterns only require pretty-printing and some formatting; they can naturally never take part in dataflow and their names are irrelevant in QL.
Most of the work goes into pattern cases gaining multiple possible patterns (which means the pattern will be entered if one or other pattern matches), and into implementing fall-through. This in particular has consequences for control flow, where pattern-case statements (which normally represent carrying out the type test(s)) need to be circumvented by fall-through flow (e.g. in the context
case A _: f(); case B _: g(); break;, the successor off()isg(), not a type test forB).