Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose helper for 1P error handling in local compilation mode #54366

Closed
wants to merge 2 commits into from
Closed

Expose helper for 1P error handling in local compilation mode #54366

wants to merge 2 commits into from
+909 −912

Conversation

pmvald
Copy link
Member

@pmvald pmvald commented Feb 9, 2024 •
edited

The linter also changes lot of unrelated lines ... just ignore! the real changes are much less!

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pmvald pmvald added action: review The PR is still awaiting reviews from at least one requested reviewer area: compiler Issues related to `ngc`, Angular's template compiler target: minor This PR is targeted for the next minor release labels Feb 9, 2024
@ngbot ngbot bot modified the milestone: Backlog Feb 9, 2024
@pmvald
refactor(compiler-cli): use a more generic error for unsupported expr…
370c4a6 
…essions in local compilation mode

A new error code `LOCAL_COMPILATION_UNSUPPORTED_EXPRESSION` is added for this purpose, replacing a narrow one.
@pmvald
refactor(compiler-cli): expose a helper to check if a diagnostic is r…
15f7852 
…elated to local compilation

Such helper is needed in 1P in order to be able to add extra google3 specific instruction to local compilation errors.
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 12, 2024
jessicajaniuk
jessicajaniuk approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@pullapprove pullapprove bot requested a review from alxhub February 12, 2024 15:30
AndrewKushnir
AndrewKushnir approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 629a222.

AndrewKushnir pushed a commit that referenced this pull request Feb 12, 2024
@pmvald @AndrewKushnir
refactor(compiler-cli): expose a helper to check if a diagnostic is r…
629a222 
…elated to local compilation (#54366)

Such helper is needed in 1P in order to be able to add extra google3 specific instruction to local compilation errors.

PR Close #54366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devversion devversion devversion approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pmvald @AndrewKushnir @devversion @jessicajaniuk