refactor(http): Deprecate HttpClientModule & related modules #54020
+912
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
changed the title
angular-robot
bot
added
detected: deprecation
JeanMeche
added
area: common/http
target: major
JeanMeche
changed the title
|
Why not reopen the other PR? (Why was it even closed without feedback? o.o) |
|
@alfaproject I pushed the branch on the repo itself, not my own fork ! |
|
We need to deprecate https://angular.io/api/common/http/testing/HttpClientTestingModule too 😄 |
|
@eneajaho Let's do that too ! |
JeanMeche
force-pushed
the
deprecate-http
branch
4 times, most recently
from
3a1da25
to
91bb73b
Compare
eneajaho
reviewed
Jan 25, 2024
JeanMeche
force-pushed
the
deprecate-http
branch
from
91bb73b
to
357d578
Compare
JeanMeche
force-pushed
the
deprecate-http
branch
from
357d578
to
e0a7f13
Compare
JeanMeche
force-pushed
the
deprecate-http
branch
from
e0a7f13
to
767d7fd
Compare
|
@JeanMeche is this change being discussed? I see Dylan wanted to talk to the team about this change. (Just wondering if/when we should review) |
dylhunn
approved these changes
Mar 28, 2024
pullapprove
bot
requested review from
alxhub,
dylhunn and
pkozlowski-opensource
|
@JeanMeche can you rebase? I'll find another public-api reviewer |
JeanMeche
force-pushed
the
deprecate-http
branch
from
767d7fd
to
a9d71ee
Compare
AndrewKushnir
approved these changes
Apr 22, 2024
This commit deprecates the `HttpClientModule` and other related http modules. Those can be replaced by provider function only. Angular is an opinionated framework, feature guidance will help developer choose the recommended way to enable feature (like Http requests here). Note: This is not an indication of deprecation for `NgModule`. The deprecated module's only purpose here was to define providers. This can be done directly by the provide function pattern. DEPRECATED: `HttpClientModule`, `HttpClientXsrfModule` and `HttpClientJsonpModule` As mentionned, those modules can be replaced by provider function only.
This migration will allow developers to migrate the deprecated `HttpClientModule`, `HttpClientJsonpModule` & `HttpClientXsrfModule` to their respective provider functions.
JeanMeche
force-pushed
the
deprecate-http
branch
from
a9d71ee
to
bad5401
Compare
alxhub
removed request for
crisbeto,
dylhunn,
pkozlowski-opensource and
atscott
|
This PR was merged into the repository by commit f914f6a. |
alxhub
pushed a commit
that referenced
this pull request
Apr 23, 2024
This migration will allow developers to migrate the deprecated `HttpClientModule`, `HttpClientJsonpModule` & `HttpClientXsrfModule` to their respective provider functions. PR Close #54020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit deprecates the
HttpClientModuleand other related http modules. Those can be replaced by provider function only.Angular is an opinionated framework, feature guidance will help developer choose the recommended way to enable features (like Http requests here).
This PR provides a migration schematics to smooth out the transition.
Note: This is NOT an indication of deprecation for NgModules. The deprecated modules only purpose was to define providers. This can be done directly by the provide function pattern.
DEPRECATION:
HttpClientModule,HttpClientXsrfModuleandHttpClientJsonpModulePreviously at #53861