C++: Report any extracted file as successfully extracted #15381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
cpp/diagnostics/successfully-extracted-filesto report any extracted file as successfully extracted, regardless of errors that might have been encountered during extraction. This is part of a cross-language effort to make the tool status page more optimistic about successfully extracted files, as apparently it was causing some users undue concern.I've also added some test cases for this and related queries so we can get a clearer idea of what's going on - though they're far from exhaustive (due to limitations in what we can easily do in tests + wide diversity of scenarios in the real world).