Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update authorizing-github-apps.md #30399

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update authorizing-github-apps.md #30399

wants to merge 1 commit into from
+1 −1

Conversation

sunilunnithan
Copy link

Why:

We see programmatic_access_type as "OAuth access token" in our logs for GitHub Enterprise

What's being changed (if available, include any code snippets, screenshots, or gifs):

Change the documentation to include the additional value.

Check off the following:

  • [X ] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • [ X] For content changes, I have completed the self-review checklist.

@welcome Welcome
Copy link

welcome bot commented Dec 6, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team. label Dec 6, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023 •
edited

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
apps/using-github-apps/authorizing-github-apps.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@myarb myarb added waiting for review Issue/PR is waiting for a writer's review github apps Content related to GitHub Apps and removed triage Do not begin working on this issue until triaged by the team. labels Dec 8, 2023
@myarb
Copy link
Contributor

myarb commented Dec 8, 2023

Thank you for opening this PR 🎉 I've triaged this for review by a team member.

@skedwards88
Copy link
Contributor

Thanks for this PR! Can you verify that you see this "OAuth access token" entry for a GitHub App, not for an OAuth app? Can you also let us know what version of GitHub Enterprise you are using?

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team more-information-needed More information is needed to complete review. labels Dec 11, 2023
@sunilunnithan
Copy link
Author

@skedwards88 We are using Databricks GitHub App - https://github.com/apps/databricks so I believe it is not OAuth App.

@skedwards88 skedwards88 added the needs SME This proposal needs review from a subject matter expert. label Dec 19, 2023
@github-actions GitHub Actions
Copy link
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@skedwards88
Copy link
Contributor

skedwards88 commented Dec 19, 2023 •
edited

Thanks for that info! I've requested some input from our SME team.

(Internal only) Asked here: https://github.com/github/ecosystem-apps/discussions/4882

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 26, 2023
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically closed because there has been no response to to our request for more information from the original author. Please reach out if you have the information we requested, or open a new issue to describing your changes. Then we can begin the review process.

@github-actions github-actions bot closed this Dec 26, 2023
@nguyenalex836
Copy link
Contributor

Apologies for our overzealous bot! I'll go ahead and reopen this PR as we are waiting for input from our SME team.

@nguyenalex836 nguyenalex836 reopened this Dec 26, 2023
@github-actions github-actions bot added triage Do not begin working on this issue until triaged by the team. and removed stale There is no recent activity on this issue or pull request labels Dec 26, 2023
@nguyenalex836 nguyenalex836 added stale There is no recent activity on this issue or pull request and removed triage Do not begin working on this issue until triaged by the team. labels Dec 26, 2023
@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Dec 26, 2023
@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

This PR has been automatically closed because there has been no response to to our request for more information from the original author. Please reach out if you have the information we requested, or open a new issue to describing your changes. Then we can begin the review process.

@github-actions github-actions bot closed this Jan 2, 2024
@nguyenalex836
Copy link
Contributor

I'll go ahead and reopen this PR again as we are waiting for input from our SME team.

@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 9, 2024
@janiceilene janiceilene removed the more-information-needed More information is needed to complete review. label Jan 9, 2024
@janiceilene janiceilene reopened this Jan 9, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team. label Jan 9, 2024
@nguyenalex836 nguyenalex836 removed the triage Do not begin working on this issue until triaged by the team. label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team github apps Content related to GitHub Apps needs SME This proposal needs review from a subject matter expert. waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sunilunnithan @myarb @skedwards88 @nguyenalex836 @janiceilene