Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update managing-a-merge-queue.md #30839

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update managing-a-merge-queue.md #30839

wants to merge 1 commit into from

Conversation

aldeed
Copy link

@aldeed aldeed commented Dec 27, 2023 •
edited

Clarify when merge_group is needed

Why:

The note mentioned both pull_request and push but seems to be relevant only to pull_request.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Clarify the language in Managing a Merge Queue article

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@aldeed
Update managing-a-merge-queue.md
7c881f1 
Clarify when `merge_group` is needed
@welcome Welcome
Copy link

welcome bot commented Dec 27, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team. label Dec 27, 2023
@github-actions GitHub Actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue.md fpt
ghec
ghes
 fpt
ghec
ghes

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@nguyenalex836
Copy link
Contributor

@aldeed Thanks so much for opening a PR! I'll get this triaged for review ✨

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review repositories Content related to repositories. and removed triage Do not begin working on this issue until triaged by the team. labels Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team repositories Content related to repositories. waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aldeed @nguyenalex836