GH-113225: Speed up `pathlib._abc.PathBase.glob()` #113556

barneygale · 2023-12-28T22:05:16Z

PathBase._scandir() is implemented using iterdir(), so we can use its results directly, rather than passing them through _make_child_relpath(). This saves a bunch of path object allocations!

Issue: Optimize pathlib.Path.iterdir() and friends by using os.DirEntry.path #113225

`PathBase._scandir()` is implemented using `iterdir()`, so we can use its results directly, rather than passing them through `_make_child_relpath()`.

pythonGH-113225: Speed up pathlib._abc.PathBase.glob()

319689f

`PathBase._scandir()` is implemented using `iterdir()`, so we can use its results directly, rather than passing them through `_make_child_relpath()`.

barneygale added skip news topic-pathlib labels Dec 28, 2023

bedevere-app bot added the awaiting core review label Dec 28, 2023

bedevere-app bot mentioned this pull request Dec 28, 2023

Optimize pathlib.Path.iterdir() and friends by using os.DirEntry.path #113225

Open

barneygale enabled auto-merge (squash) December 28, 2023 22:07

barneygale merged commit b664d91 into python:main Dec 28, 2023
30 checks passed

bedevere-app bot removed the awaiting core review label Dec 28, 2023

barneygale mentioned this pull request Dec 28, 2023

GH-113225: Speed up pathlib.Path.glob() #113226

Merged

GH-113225: Speed up pathlib._abc.PathBase.glob() #113556

GH-113225: Speed up pathlib._abc.PathBase.glob() #113556

Conversation

barneygale commented Dec 28, 2023 • edited

GH-113225: Speed up `pathlib._abc.PathBase.glob()` #113556

GH-113225: Speed up `pathlib._abc.PathBase.glob()` #113556

barneygale commented Dec 28, 2023 •

edited