Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-102840: Fix confused traceback when floordiv or mod operations happens between Fraction and complex objects #102842

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

gh-102840: Fix confused traceback when floordiv or mod operations happens between Fraction and complex objects #102842

wants to merge 5 commits into from
+46 −19

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Mar 20, 2023 •
edited by bedevere-bot

@bedevere-bot bedevere-bot mentioned this pull request Mar 20, 2023
Open
@Eclips4
Copy link
Member Author

Eclips4 commented Mar 20, 2023

cc @skirpichev

skirpichev
skirpichev suggested changes Mar 20, 2023
View reviewed changes
Lib/fractions.py Show resolved Hide resolved
Lib/fractions.py Show resolved Hide resolved
@Eclips4 Eclips4 requested a review from skirpichev March 20, 2023 12:36
skirpichev
skirpichev suggested changes Mar 20, 2023
View reviewed changes
Lib/test/test_fractions.py Outdated Show resolved Hide resolved
@Eclips4 @skirpichev
Add sugestion from skirpichev
b03522e 
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@Eclips4
Copy link
Member Author

Eclips4 commented Mar 20, 2023

Also, I think there no need in NEWS entry. But if someone want it - I'll add it.

skirpichev
skirpichev approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arhadthedev arhadthedev added the stdlib Python modules in the Lib dir label Mar 22, 2023
@arhadthedev
Copy link
Member

@mdickinson (as a fraction expert)

Eclips4
Eclips4 commented Jan 1, 2024
View reviewed changes
Lib/test/test_fractions.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirpichev skirpichev skirpichev approved these changes

Assignees
No one assigned
Labels
awaiting core review stdlib Python modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Eclips4 @arhadthedev @skirpichev @bedevere-bot