Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete documentation for cs/web/broad-cookie-domain #15169

Open
johnaceous opened this issue Dec 19, 2023 · 1 comment
Open

Incomplete documentation for cs/web/broad-cookie-domain #15169

johnaceous opened this issue Dec 19, 2023 · 1 comment
Labels
C# documentation

Comments

@johnaceous
Copy link

I believe the CodeQL documentation here conflicts with MDN by omission:

In this example cookie1 is accessible from online-bank.com ...

        HttpCookie cookie1 = new HttpCookie("sessionID");
        cookie1.Domain = "online-bank.com";

https://codeql.github.com/codeql-query-help/csharp/cs-web-broad-cookie-domain/

According to MDN, that cookie would also be available to subdomains:

For example, if you set Domain=mozilla.org, cookies are available on mozilla.org and its subdomains like developer.mozilla.org.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies#domain_attribute

The CodeQL documentation should state that "In this example cookie1 is accessible from online-bank.com and its subdomains".
@johnaceous johnaceous added the question Further information is requested label Dec 19, 2023
@aeisenberg aeisenberg added C# documentation and removed question Further information is requested labels Dec 20, 2023
@aeisenberg
Copy link
Contributor

Thanks for mentioning this. I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C# documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aeisenberg @johnaceous