Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix numeric comparison in Filtering projects #30784

Merged
merged 1 commit into from Jan 2, 2024
Merged

Fix numeric comparison in Filtering projects #30784

merged 1 commit into from Jan 2, 2024

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Dec 20, 2023

Why:

The table looks to incorrectly repeat the >= comparison.

Closes:

#30783

What's being changed (if available, include any code snippets, screenshots, or gifs):

Fixing the table so that the >= qualifier isn't repeated.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@ehuss
Fix numeric comparison in Filtering projects
3fd2627 
The table looks to incorrectly repeat the `>=` comparison.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team. label Dec 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
issues/planning-and-tracking-with-projects/customizing-views-in-your-project/filtering-projects.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@nguyenalex836 nguyenalex836 linked an issue Dec 20, 2023 that may be closed by this pull request
Filtering projects table incorrectly duplicates the >= comparison #30783
Closed
1 task
@nguyenalex836
Copy link
Contributor

@ehuss Thanks so much for opening a PR! I've went ahead and linked the associated issue you filed to this PR. I'll get this triaged for review ✨

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team issues Content related to issues. waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team. labels Dec 20, 2023
@mchammer01 mchammer01 self-requested a review December 21, 2023 14:44
mchammer01
mchammer01 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehuss - thanks for reporting, and fixing this mistake ✨
LGTM :shipit:

@fwadnjar

This comment was marked as spam.

Sign in to view
@fwadnjar

This comment was marked as spam.

Sign in to view
@fwadnjar

This comment was marked as spam.

Sign in to view
@fwadnjar

This comment was marked as spam.

Sign in to view
@mchammer01 mchammer01 added this pull request to the merge queue Jan 2, 2024
Merged via the queue into github:main with commit a5bde76 Jan 2, 2024
86 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchammer01 mchammer01 mchammer01 approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team issues Content related to issues. waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filtering projects table incorrectly duplicates the >= comparison
4 participants
@ehuss @nguyenalex836 @fwadnjar @mchammer01