Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Fix Log forging false positive. #15212

Merged
merged 4 commits into from Jan 4, 2024
Merged

C#: Fix Log forging false positive. #15212

merged 4 commits into from Jan 4, 2024
+16 −10

Conversation

michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Jan 3, 2024 •
edited

It turns out that there more overloads of the String.Replace method, which we didn't consider replace methods.

@michaelnebel michaelnebel mentioned this pull request Jan 3, 2024
Closed
@michaelnebel michaelnebel marked this pull request as ready for review January 3, 2024 12:21
@michaelnebel michaelnebel requested a review from a team as a code owner January 3, 2024 12:21
@michaelnebel
Copy link
Contributor Author

DCA looks good.

@michaelnebel michaelnebel merged commit 682aef9 into github:main Jan 4, 2024
22 checks passed
@michaelnebel michaelnebel deleted the csharp/stringreplace branch January 4, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved hvitved approved these changes

Assignees
No one assigned
Labels
C# documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaelnebel @hvitved