Go: fix FP in incorrect integer conversion query relating to strict comparisons with MaxInt and MaxUint #15128
+17
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cause of the test failure is confusion about whether the architecture is 32 bit or 64 bit.
It was wrong for strictnessOffset = 1 before.
owen-mc
force-pushed
the
go/fix-fp-incorrect-integer-conversion-signedness
branch
from
454ba3a
to
5a2c48f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new logic for comparing with MaxInt and MaxUint had a logic error which affected strict inequailities. So
x <= MaxUintwould work butx < MaxUintwouldn't.