Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove indent_size = 2 from editorconfig as it messes up the continuation indent #16233

Merged
merged 1 commit into from Jun 10, 2019
Merged

chore: remove indent_size = 2 from editorconfig as it messes up the continuation indent #16233

merged 1 commit into from Jun 10, 2019

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Jun 7, 2019

No description provided.

@mmalerba mmalerba added merge safe This PR does not affect library code used inside Google and can be merged without a Google presubmit target: patch This PR is targeted for the next patch release labels Jun 7, 2019
@mmalerba mmalerba requested a review from jelbourn Jun 7, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 7, 2019
jelbourn
jelbourn approved these changes Jun 7, 2019
View changes
Copy link
Member

@jelbourn jelbourn left a comment

LGTM

@jelbourn jelbourn added pr: lgtm action: merge This PR is ready to run through Google's internal presubmit labels Jun 7, 2019
@josephperrott josephperrott merged commit 4a934c6 into angular:master Jun 10, 2019
13 checks passed
josephperrott pushed a commit that referenced this pull request Jun 10, 2019
@mmalerba @josephperrott
chore: remove indent_size = 2 from editorconfig as it messes up the (…
ee01689 
…#16233)

continuation indent
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@mmalerba @RudolfFrederiksen
chore: remove indent_size = 2 from editorconfig as it messes up the (…
5d4824e 
…angular#16233)

continuation indent
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn

Assignees

@jelbourn jelbourn

Labels
action: merge This PR is ready to run through Google's internal presubmit cla: yes PR author has agreed to Google's Contributor License Agreement merge safe This PR does not affect library code used inside Google and can be merged without a Google presubmit target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mmalerba @jelbourn @googlebot @josephperrott