Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive: it is valid to escape $ in javascript template string syntax #15077

Open
rictic opened this issue Dec 12, 2023 · 0 comments
Open

False positive: it is valid to escape $ in javascript template string syntax #15077

rictic opened this issue Dec 12, 2023 · 0 comments
Labels
false-positive

Comments

@rictic
Copy link

rictic commented Dec 12, 2023

Description of the false positive

js/useless-regexp-character-escape triggers for code like:

const str = `hello \${name}`;

This is invalid, since without the backslash escape, that's a string interpolation of the name variable:

const str = `hello ${name}`;

This triggered in the lit-html codebase on this line: https://github.com/lit/lit/blob/5eea178e0df1199cd29e9d46bc888d52882f18dd/packages/lit-html/src/lit-html.ts#L1418

Link to the code scanning issue: https://github.com/lit/lit/security/code-scanning/15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
false-positive
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rictic