Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend doc about reusable workflows containing several jobs #30296

Open
1 of 4 tasks
SimonHeimberg opened this issue Dec 1, 2023 · 2 comments
Open
1 of 4 tasks

extend doc about reusable workflows containing several jobs #30296

SimonHeimberg opened this issue Dec 1, 2023 · 2 comments
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Comments

@SimonHeimberg
Copy link

SimonHeimberg commented Dec 1, 2023

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-outputs-from-a-reusable-workflow

What part(s) of the article would you like to see updated?

reusable workflows seem to support containing several jobs (mentioned at the start)
please extend documentation

  • that this is not possible (in limitations, except if it is)
  • Add example code for a job depending on a workflow containing several jobs.
  • how to depend on the result of one job which in inside of the reusable workflow
    (maybe with job name: calling-job-name/reusalable-job-name)
    Directly depending on an "inner" job is not possible, job outputs can be used instead
  • Please explain how the results of "inner" jobs influence the result of the calling job. (any fails -> fail, most pass but some skipped -> pass, all skipped ->?s?p ) , failure probably depends on jobs.<job_id>.continue-on-error
  • Mention "branch protection rules" (or rulesets) can only depend on "leave" jobs. (Not the caller job.)

Additional information

I tried out to have several jobs in a reusable workflow in a test repo https://github.com/SimonHeimberg/temp_test_github_merge/actions/runs/7065558500/job/19235804814

Looks like my test is somehow wrong. How it is displayed indicates that this is supported, as the documentation. But after hours I still wait for the jobs to be picked up by a runner. So running seems to be NOT be supported. But I did not get any result because I used a wrong runner name. 🙈

@SimonHeimberg SimonHeimberg added the content This issue or pull request belongs to the Docs Content team label Dec 1, 2023
Copy link

welcome bot commented Dec 1, 2023

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team. label Dec 1, 2023
@steveward steveward added waiting for review Issue/PR is waiting for a writer's review actions This issue or pull request should be reviewed by the docs actions team and removed triage Do not begin working on this issue until triaged by the team. labels Dec 1, 2023
@SimonHeimberg SimonHeimberg changed the title reusable workflows seem to support containing several jobs, please document it reusable workflows might to support containing several jobs, please document it Dec 2, 2023
@SimonHeimberg SimonHeimberg changed the title reusable workflows might to support containing several jobs, please document it reusable workflows seem NOT to support containing several jobs, please document it Dec 2, 2023
@SimonHeimberg
Copy link
Author

I was wrong, the doc shows at top that multiple jobs can be included. I suggest to show this as well in a code example.

@SimonHeimberg SimonHeimberg changed the title reusable workflows seem NOT to support containing several jobs, please document it extend doc about reusable workflows containing several jobs Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

No branches or pull requests

4 participants
@steveward @SimonHeimberg and others