Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Remove unneeded options and add support for paths/paths-ignore in standalone #15070

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tamasvajk
Copy link
Contributor

@tamasvajk tamasvajk commented Dec 12, 2023

This PR

  • removes all the unused options from the standalone extractor,
  • handles the LGTM_INDEX_FILTERS environment variable, which contains the paths and paths-ignore codescanning settings.

The CI QL Tests are failing due to the removal of the options. The linked internal PR covers those.

@github-actions github-actions bot added the C# label Dec 12, 2023
@tamasvajk tamasvajk force-pushed the standalone/exclusions branch 8 times, most recently from 3edebeb to a4cfc07 Compare December 13, 2023 10:35
include:c/x/y
""");

var filtered = testSubject.Filter(files);

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

This assignment to
filtered
is useless, since its value is never read.
exclude:c/d/e
""");

var filtered = testSubject.Filter(files);

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

This assignment to
filtered
is useless, since its value is never read.
exclude:**/z/i.cs
""");

var filtered = testSubject.Filter(files);

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

This assignment to
filtered
is useless, since its value is never read.
@tamasvajk tamasvajk changed the title C#: Remove unneeded options from standalone extractor C#: Remove unneeded options and add support for paths/paths-ignore in standalone Dec 13, 2023
@tamasvajk tamasvajk marked this pull request as ready for review December 13, 2023 13:15
@tamasvajk tamasvajk requested a review from a team as a code owner December 13, 2023 13:15
exclude:c/x/z
""");

var filtered = testSubject.Filter(files);

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

This assignment to
filtered
is useless, since its value is never read.
include:c/x
""");

var filtered = testSubject.Filter(files);

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

This assignment to
filtered
is useless, since its value is never read.
exclude:**/z/i.cs
""");

var filtered = testSubject.Filter(files);

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

This assignment to
filtered
is useless, since its value is never read.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant