New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby: Model some libraries with the model editor #15035
Draft
hmac
wants to merge
20
commits into
github:main
Choose a base branch
from
hmac:hmac-modgen-subclasses
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hmac
commented
Dec 7, 2023
- Ruby: Include external sinks from MaD
- Ruby: Model mysql2
- Ruby: Add partial model for httparty
- Ruby: Include request forgery sinks from MaD
- Ruby: Move mysql model, model half of rack
- Ruby: Add partial model for httparty
- Ruby: Include ancestors in type model generation
Add experimental support for the CodeQL Model Editor.
For model editing purposes.
This allows the model editor to find this query in a more robust way than by file path.
Gemspecs are sometimes named via the first argument to `Gem::Specification.new`: ```rb Gem::Specification.new 'sinatra' do |s| # ... end ```
This allows us to render type relations between modules/classes, not just methods.
cf4b6e5
to
e537b65
Compare
| private import codeql.ruby.frameworks.data.internal.ApiGraphModelsExtensions | ||
| private import queries.modeling.internal.Util as Util | ||
| private import codeql.util.Unit | ||
| private import codeql.ruby.AST |
Check warning
Code scanning / CodeQL
Redundant import Warning
Redundant import, the module is already imported inside .
codeql.ruby.dataflow.FlowSummary
Error loading related location
| private import queries.modeling.internal.Util as Util | ||
| private import codeql.util.Unit | ||
| private import codeql.ruby.AST | ||
| private import codeql.ruby.ast.Module |
Check warning
Code scanning / CodeQL
Redundant import Warning
Redundant import, the module is already imported inside .
codeql.ruby.AST
Error loading related location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.