Skip to content

perf(android): gridlayout with less JNI calls #10402

Merged
NathanWalker merged 10 commits into
NativeScript:mainfrom
Akylas:gridlayout_android
Jul 1, 2024
Merged

perf(android): gridlayout with less JNI calls #10402
NathanWalker merged 10 commits into
NativeScript:mainfrom
Akylas:gridlayout_android

Conversation

@farfromrefug
Copy link
Copy Markdown
Collaborator

@farfromrefug farfromrefug commented Oct 10, 2023

A rewrite of GridLayout on Android to makes less JNI calls. The result is around 30% time gained on average GridLayout

@cla-bot cla-bot Bot added the cla: yes label Oct 10, 2023
@NathanWalker NathanWalker added this to the 8.7 milestone Oct 10, 2023
@NathanWalker NathanWalker modified the milestones: 8.7, 8.8 Jun 28, 2024
@NathanWalker NathanWalker changed the title fix(android): rewrite the GridLayout to make as less JNI calls as pos… perf(android): gridlayout with less JNI calls Jun 28, 2024
@NathanWalker
Copy link
Copy Markdown
Contributor

NathanWalker commented Jun 28, 2024

@farfromrefug possible to peek at the failing android tests? I merged latest and also rebuild the ui-mobile-base widgets (aka, TNSWidgets) since this has a .java change on it) and seems we have the following failing tests with these changes:

 Test: GRIDLAYOUT.test_removeColumns FAILED: Cannot convert number to Lorg/nativescript/widgets/GridUnitType; at index 1
 Test: GRIDLAYOUT.test_removeRows FAILED: Cannot convert number to Lorg/nativescript/widgets/GridUnitType; at index 1
 Test: GRIDLAYOUT.test_removeChildren FAILED: Cannot convert number to Lorg/nativescript/widgets/GridUnitType; at index 1
 Test: GRIDLAYOUT.test_measuredWidth_when_not_stretched_two_columns FAILED: Cannot convert number to Lorg/nativescript/widgets/GridUnitType; at index 1
 Test: GRIDLAYOUT.test_measuredWidth_when_not_stretched_three_columns FAILED: Cannot convert number to Lorg/nativescript/widgets/GridUnitType; at index 1
 Test: GRIDLAYOUT.test_desiredSize_isCorrect FAILED: Cannot convert number to Lorg/nativescript/widgets/GridUnitType; at index 1
 Test: GRIDLAYOUT.test_columnsActualWidth_isCorrect FAILED: Cannot convert number to Lorg/nativescript/widgets/GridUnitType; at index 1
 Test: GRIDLAYOUT.test_rowsActualHeight_isCorrect FAILED: Cannot convert number to Lorg/nativescript/widgets/GridUnitType; at index 1
 Test: GRIDLAYOUT.test_Measure_and_Layout_Children_withCorrect_size FAILED: Cannot convert number to Lorg/nativescript/widgets/GridUnitType; at index 1
 Test: GRIDLAYOUT.test_ColumnWidth_when_4stars_and_width_110 FAILED: Cannot convert number to Lorg/nativescript/widgets/GridUnitType; at index 1
 Test: GRIDLAYOUT.test_columns_widths FAILED: Cannot convert number to Lorg/nativescript/widgets/GridUnitType; at index 1

Link to test run here: https://github.com/NativeScript/NativeScript/actions/runs/9719521521/job/26829475734?pr=10402

@farfromrefug
Copy link
Copy Markdown
Collaborator Author

farfromrefug commented Jun 29, 2024

@NathanWalker will take a look

@farfromrefug
Copy link
Copy Markdown
Collaborator Author

farfromrefug commented Jun 29, 2024

@NathanWalker i did fix some tests. now i am facing a dilemma. Some tests like this one https://github.com/Akylas/NativeScript/blob/b9d5ba1c53987a7bbc3a8430b327c96dac03eb8c/apps/automated/src/ui/layouts/grid-layout-tests.ts#L372 are still failing. The reason is that before my PR on the JS side _cols and _rows were actually native objects modified from the native side (org.nativescript.widgets.ItemSpec). Then on those native objects _actualLength to assert the tests.
But that only existed for the tests and makes GridLayout slower as we maintain and access native objects from the JS side. So i dont think we should keep on doing it that way.
I can create special methods in the android GridLayout to query that _actualLength for the purpose of the tests. However it means the tests will be different on iOS / Android. IS that ok?

@NathanWalker
Copy link
Copy Markdown
Contributor

NathanWalker commented Jun 29, 2024

Thanks for explaining, I think that’d be okay 👍

@farfromrefug
Copy link
Copy Markdown
Collaborator Author

farfromrefug commented Jul 1, 2024

@NathanWalker should be good now

@NathanWalker NathanWalker merged commit 6dd441d into NativeScript:main Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NathanWalker NathanWalker NathanWalker approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

8.8

Development

Successfully merging this pull request may close these issues.

2 participants

@farfromrefug @NathanWalker