Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: convert build/test scripts to use fast-glob #53397

Closed
wants to merge 1 commit into from

Conversation

clydin
Copy link
Member

@clydin clydin commented Dec 6, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

The repository currently has two globbing packages. To minimize the number of packages in the framework repository, the uses of the glob package are being converted to fast-glob which is also used by the tooling repository. The change is mostly mechanical and in this change the build and test scripts are converted.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@clydin clydin added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Dec 6, 2023
@clydin clydin requested a review from devversion December 6, 2023 16:39
@pullapprove pullapprove bot requested review from alxhub and dgp1130 December 6, 2023 16:39
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Dec 6, 2023
@ngbot ngbot bot added this to the Backlog milestone Dec 6, 2023
The repository currently has two globbing packages. To minimize the number of packages in
the framework repository, the uses of the `glob` package are being converted
to `fast-glob` which is used by the tooling repository.  The change is mostly mechanical
and in this change the build and test scripts are converted.
@clydin clydin force-pushed the deps/fast-glob/infra branch from 8561c5a to fb9d851 Compare December 6, 2023 16:45
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: global-dev-infra-approvers

@clydin clydin added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 7, 2023
@clydin
Copy link
Member Author

clydin commented Dec 7, 2023

CARETAKER: Github refuses to remove extra reviewers which is the only reason CI is still pending.

@alxhub
Copy link
Member

alxhub commented Dec 8, 2023

This PR was merged into the repository by commit f2245d1.

@alxhub alxhub closed this in f2245d1 Dec 8, 2023
@clydin clydin deleted the deps/fast-glob/infra branch December 8, 2023 23:46
josephperrott pushed a commit to josephperrott/angular that referenced this pull request Dec 11, 2023
The repository currently has two globbing packages. To minimize the number of packages in
the framework repository, the uses of the `glob` package are being converted
to `fast-glob` which is used by the tooling repository.  The change is mostly mechanical
and in this change the build and test scripts are converted.

PR Close angular#53397
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 8, 2024
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
The repository currently has two globbing packages. To minimize the number of packages in
the framework repository, the uses of the `glob` package are being converted
to `fast-glob` which is used by the tooling repository.  The change is mostly mechanical
and in this change the build and test scripts are converted.

PR Close angular#53397
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
The repository currently has two globbing packages. To minimize the number of packages in
the framework repository, the uses of the `glob` package are being converted
to `fast-glob` which is used by the tooling repository.  The change is mostly mechanical
and in this change the build and test scripts are converted.

PR Close angular#53397
danieljancar pushed a commit to danieljancar/angular that referenced this pull request Jan 26, 2024
The repository currently has two globbing packages. To minimize the number of packages in
the framework repository, the uses of the `glob` package are being converted
to `fast-glob` which is used by the tooling repository.  The change is mostly mechanical
and in this change the build and test scripts are converted.

PR Close angular#53397
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
The repository currently has two globbing packages. To minimize the number of packages in
the framework repository, the uses of the `glob` package are being converted
to `fast-glob` which is used by the tooling repository.  The change is mostly mechanical
and in this change the build and test scripts are converted.

PR Close angular#53397
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants