Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(forms): replace fb with formBuilder #52795

Closed
wants to merge 1 commit into from

Conversation

ice-blaze
Copy link
Contributor

Shorten variable names isn't a good practice. To avoid spreading it, we removed it from Angular's documentation.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #52260

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Didn't change it in the unit tests since there are way more abbreviations there. But could do it if necessary.

Shorten variable names isn't a good practice. To avoid spreading it, we removed it from Angular's documentation.
@pullapprove pullapprove bot requested review from atscott and twerske November 10, 2023 19:20
@angular-robot angular-robot bot added the area: docs Related to the documentation label Nov 10, 2023
@ngbot ngbot bot added this to the Backlog milestone Nov 10, 2023
@atscott atscott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 10, 2023
@jessicajaniuk jessicajaniuk requested review from josephperrott and removed request for twerske November 13, 2023 18:23
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 9e2c3bb.

jessicajaniuk pushed a commit that referenced this pull request Nov 13, 2023
Shorten variable names isn't a good practice. To avoid spreading it, we removed it from Angular's documentation.

PR Close #52795
tbondwilkinson pushed a commit to tbondwilkinson/angular that referenced this pull request Dec 6, 2023
Shorten variable names isn't a good practice. To avoid spreading it, we removed it from Angular's documentation.

PR Close angular#52795
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 14, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
Shorten variable names isn't a good practice. To avoid spreading it, we removed it from Angular's documentation.

PR Close angular#52795
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
Shorten variable names isn't a good practice. To avoid spreading it, we removed it from Angular's documentation.

PR Close angular#52795
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
Shorten variable names isn't a good practice. To avoid spreading it, we removed it from Angular's documentation.

PR Close angular#52795
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants