fix(compiler-cli): avoid conflicts with built-in global variables in for loop blocks #53319
+58
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for loop blocks Currently we generate the following TCB for a `@for` loop: ```ts // @for (item of items; track item) {...} for (const item of this.items) { var _t1 = item; // Do things with `_t1` } ``` This is problematic if the item name is the same as a global variable (e.g. `document`), because when the TCB has references to that variable (e.g. `document.createElement`), it'll find the loop initializer instead of the global variable. These changes fix the issue by generating the following instead: ```ts for (const _t1 of this.items) { // Do things with `_t1` } ``` Fixes angular#53293.
crisbeto
added
action: review
JoostK
approved these changes
Dec 2, 2023
crisbeto
added
action: merge
|
This PR was merged into the repository by commit d7a83f9. |
dylhunn
pushed a commit
that referenced
this pull request
Dec 5, 2023
…for loop blocks (#53319) Currently we generate the following TCB for a `@for` loop: ```ts // @for (item of items; track item) {...} for (const item of this.items) { var _t1 = item; // Do things with `_t1` } ``` This is problematic if the item name is the same as a global variable (e.g. `document`), because when the TCB has references to that variable (e.g. `document.createElement`), it'll find the loop initializer instead of the global variable. These changes fix the issue by generating the following instead: ```ts for (const _t1 of this.items) { // Do things with `_t1` } ``` Fixes #53293. PR Close #53319
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
…for loop blocks (angular#53319) Currently we generate the following TCB for a `@for` loop: ```ts // @for (item of items; track item) {...} for (const item of this.items) { var _t1 = item; // Do things with `_t1` } ``` This is problematic if the item name is the same as a global variable (e.g. `document`), because when the TCB has references to that variable (e.g. `document.createElement`), it'll find the loop initializer instead of the global variable. These changes fix the issue by generating the following instead: ```ts for (const _t1 of this.items) { // Do things with `_t1` } ``` Fixes angular#53293. PR Close angular#53319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we generate the following TCB for a
@forloop:This is problematic if the item name is the same as a global variable (e.g.
document), because when the TCB has references to that variable (e.g.document.createElement), it'll find the loop initializer instead of the global variable.These changes fix the issue by generating the following instead:
Fixes #53293.