Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-59254: mention in open() doc that line buffering is for writing #112318

Merged
merged 1 commit into from Nov 24, 2023
Merged

gh-59254: mention in open() doc that line buffering is for writing #112318

merged 1 commit into from Nov 24, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Nov 22, 2023 •
edited by github-actions bot

@bedevere-app bedevere-app bot mentioned this pull request Nov 22, 2023
Closed
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Nov 22, 2023
@iritkatriel iritkatriel added needs backport to 3.11 bug and security fixes needs backport to 3.12 bug and security fixes labels Nov 22, 2023
@pitrou pitrou merged commit fafae08 into python:main Nov 24, 2023
31 checks passed
@miss-islington-app
Copy link

Thanks @iritkatriel for the PR, and @pitrou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤄1�7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2023
@iritkatriel @miss-islington
pythongh-59254: mention in open() doc that line buffering is for writ 1�7
fee6aea 
…ing (pythonGH-112318)

(cherry picked from commit fafae08)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2023
@iritkatriel @miss-islington
pythongh-59254: mention in open() doc that line buffering is for writ 1�7
62dab2f 
…ing (pythonGH-112318)

(cherry picked from commit fafae08)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 24, 2023

GH-112378 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 24, 2023
@bedevere-app
Copy link

bedevere-app bot commented Nov 24, 2023

GH-112379 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 bug and security fixes label Nov 24, 2023
iritkatriel added a commit that referenced this pull request Nov 24, 2023
@miss-islington @iritkatriel
[3.11] gh-59254: mention in open() doc that line buffering is for wri 1�7
669b8fa 
…ting (GH-112318) (#112379)

gh-59254: mention in open() doc that line buffering is for writing (GH-112318)
(cherry picked from commit fafae08)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
iritkatriel added a commit that referenced this pull request Nov 24, 2023
@miss-islington @iritkatriel
[3.12] gh-59254: mention in open() doc that line buffering is for wri 1�7
103728d 
…ting (GH-112318) (#112378)

gh-59254: mention in open() doc that line buffering is for writing (GH-112318)
(cherry picked from commit fafae08)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[doc] say in open() doc that line buffering only applies to write
2 participants
@iritkatriel @pitrou