Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(docs-infra): add tab titles to home, playground and tutorial #53026

Closed
wants to merge 1 commit into from
Closed

docs(docs-infra): add tab titles to home, playground and tutorial #53026

wants to merge 1 commit into from
+3 −1

Conversation

aramirezj
Copy link
Contributor

@aramirezj aramirezj commented Nov 18, 2023 •
edited by JeanMeche

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Currently, in Angular dev, the home, the playground and the tutorials does not have a specific title, only has "Angular". On the other hand, the option of the sidenav Reference and Docs have specific title being for each one:

  • API Reference * Overview * Angular
  • What is Angular? * Angular

Without
image
image
image

With
image
image

Issue Number: Fixes 53020

What is the new behavior?

With the new behaviour, the routes that had only Angular, now should have their own label plus * Angular

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Since adev cannot be compiled and tested locally, these changes havent been tried, but I think they should work, if this PR should be block till adev can be tested locally I would totally understand.

Thanks!

@pullapprove pullapprove bot requested a review from twerske November 18, 2023 18:32
@angular-robot angular-robot bot added the area: docs Related to the documentation label Nov 18, 2023
@ngbot ngbot bot added this to the Backlog milestone Nov 18, 2023
@JeanMeche JeanMeche added state: blocked area: adev-infra Angular.dev application and infrastructure labels Nov 18, 2023
@JeanMeche
Copy link
Member

JeanMeche commented Nov 18, 2023 •
edited

I'm marking this as blocked until the infra is setup to test the result.
Btw can you reword your commit and make this a docs(docs-infra): ...

@aramirezj
Copy link
Contributor Author

I'm marking this as blocked until the infra is setup to test the result. Btw can you reword your commit and make this a docs(docs-infra): ...

Seems good! I have read a few times the contributing.md but still didnt get it right XD, I will reword the commit, thanks!

@aramirezj aramirezj changed the title docs: add tab titles to home, playground and tutorial docs(docs-infra): add tab titles to home, playground and tutorial Nov 18, 2023
@twerske
Copy link
Contributor

twerske commented Nov 29, 2023

As @JeanMeche mentioned - this is blocked but I'll review once we can have a build preview!

@twerske twerske added the target: patch This PR is targeted for the next patch release label Nov 29, 2023
@aramirezj
Copy link
Contributor Author

As @JeanMeche mentioned - this is blocked but I'll review once we can have a build preview!

Perfect, thank you so much Emma!

@pullapprove pullapprove bot requested a review from jelbourn January 25, 2024 23:22
@github-actions GitHub Actions
Copy link

Deployed adev-preview for 702eed3 to: https://ng-dev-previews-fw--pr-angular-angular-53026-adev-prev-mtoo2ru1.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

JeanMeche
JeanMeche approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine thx !

Just one thing @twerske, do we want the "Home" for the home page ?

jessicajaniuk
jessicajaniuk approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessicajaniuk jessicajaniuk added the action: merge The PR is ready for merge by the caretaker label Jan 31, 2024
@aramirezj
Copy link
Contributor Author

Thanks for the reviews guys! ^^

jessicajaniuk pushed a commit that referenced this pull request Jan 31, 2024
@aramirezj @jessicajaniuk
docs(docs-infra): add tab titles to home, playground and tutorial (#5…
ed8e7c7 
…3026)

PR Close #53026
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit a297012.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: adev-infra Angular.dev application and infrastructure area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Page titles are not distinguishable
4 participants
@aramirezj @JeanMeche @twerske @jessicajaniuk