docs(compiler-cli): ng new does not generate app.module.ts #52761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Can you please also add this to |
lucasluizss
force-pushed
the
fix-doc-standalone-default-cli
branch
from
d10e779
to
d378e55
Compare
twerske
approved these changes
Nov 9, 2023
twerske
added
area: aio
KlausEverWalkingDev
approved these changes
Nov 10, 2023
josephperrott
requested review from
jelbourn
and removed request for
josephperrott
|
@jelbourn, can you take a look at the wording here? |
twerske
approved these changes
Nov 29, 2023
twerske
added
target: patch
jelbourn
reviewed
Jan 18, 2024
There was a problem hiding this comment.
Missed the original notification on this one-
I think this update is obsolete now; the current reference table includes the line:
Only generated when using the --standalone false option.
For the local setup guide, I don't think the absence of the module file needs an explicit callout
|
Deployed adev-preview for d378e55 to: https://ng-dev-previews-fw--pr-angular-angular-52761-adev-prev-von7u6v6.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
|
Per Jeremy, we'll go with the current changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
fixes #52751
What is the new behavior?
Does this PR introduce a breaking change?
Other information