Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive - Ruby on Rails: SQL query built from user-controlled sources #14546

Open
kostyanf14 opened this issue Oct 19, 2023 · 2 comments
Open

False positive - Ruby on Rails: SQL query built from user-controlled sources #14546

kostyanf14 opened this issue Oct 19, 2023 · 2 comments
Labels
acknowledged GitHub staff acknowledges this issue false-positive Ruby

Comments

@kostyanf14
Copy link

Description of the false positive

Rails execute sanitize_sql_for_assignment when update_all called with an array as the argument:
https://github.com/rails/rails/blob/v7.0.8/activerecord/lib/active_record/relation.rb#L476

Code samples or links to source code

https://github.com/amnis-invictus/ikt.edu.vn.ua/blob/e404674b8efd9c4ed668866787a8a2ef1b91514f/app/channels/api_channel.rb#L82
https://github.com/amnis-invictus/ikt.edu.vn.ua/blob/e404674b8efd9c4ed668866787a8a2ef1b91514f/app/channels/api_channel.rb#L85

URL to the alert on GitHub code scanning (optional)

https://github.com/amnis-invictus/ikt.edu.vn.ua/security/code-scanning/307
https://github.com/amnis-invictus/ikt.edu.vn.ua/security/code-scanning/308
@jketema
Copy link
Contributor

jketema commented Oct 19, 2023

Hi @kostyanf14,

Thanks for your report. I've asked the Ruby engineering team to take a look.

@sidshank sidshank added the Ruby label Oct 19, 2023
@jketema
Copy link
Contributor

jketema commented Oct 19, 2023

Hi @kostyanf14,

The engineering team agrees this is false positive, and they've opened an internal issue to track this. Thanks for the report!

@sidshank sidshank added the acknowledged GitHub staff acknowledges this issue label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledged GitHub staff acknowledges this issue false-positive Ruby
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sidshank @kostyanf14 @jketema