Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md #29848

Merged
merged 2 commits into from Jan 9, 2024
Merged

Update generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md #29848

merged 2 commits into from Jan 9, 2024

Conversation

cinnamondev
Copy link
Contributor

@cinnamondev cinnamondev commented Nov 10, 2023 •
edited

Rephrases the step so that it is clear that is only possible to execute the command within an elevated PowerShell window.

Why:

Closes: #29847

What's being changed (if available, include any code snippets, screenshots, or gifs):

Step 1 is rephrased so it is clear that the commands are only executable in PowerShell ("In a new admin elevated PowerShell window, ensure...")

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@cinnamondev
Update generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md
4ea183f 
The provided example command specifically refers to powershell commands. Alternatively replace example with calls to `sc`.
@welcome Welcome
Copy link

welcome bot commented Nov 10, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team. label Nov 10, 2023
@github-actions GitHub Actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae
 fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

cmwilson21 commented Nov 10, 2023 •
edited

@cinnamondev Thank you for opening a PR and linking it to your issue! ✨

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review ssh Content related to ssh. authentication Content relating to authentication. and removed triage Do not begin working on this issue until triaged by the team. labels Nov 10, 2023
stevecat
stevecat approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@stevecat stevecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this, @cinnamondev! ✨ Your changes look great and we'll get this merged in the new year.

@stevecat stevecat added the ready to merge This pull request is ready to merge label Dec 22, 2023
@docs-bot docs-bot added this to Triage in Docs open source board Dec 22, 2023
@nguyenalex836 nguyenalex836 added this pull request to the merge queue Jan 9, 2024
Merged via the queue into github:main with commit 5520706 Jan 9, 2024
39 checks passed
Docs open source board automation moved this from Triage to Done Jan 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevecat stevecat stevecat approved these changes

Assignees
No one assigned
Labels
authentication Content relating to authentication. content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge ssh Content related to ssh. waiting for review Issue/PR is waiting for a writer's review
Projects
Docs open source board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Steps to start SSH agent in "Generate new SSH key" provide incorrect information
4 participants
@cinnamondev @cmwilson21 @stevecat @nguyenalex836