New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(migrations): Add support for removing imports post migration #52763
Closed
+386
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2128661
to
686688a
Compare
crisbeto
reviewed
Nov 10, 2023
packages/core/schematics/ng-generate/control-flow-migration/util.ts
Outdated
Show resolved
Hide resolved
686688a
to
b7f6065
Compare
bab9257
to
ca6eea0
Compare
crisbeto
approved these changes
Nov 13, 2023
packages/core/schematics/ng-generate/control-flow-migration/index.ts
Outdated
Show resolved
Hide resolved
ca6eea0
to
fe2420f
Compare
This update removes imports from component decorators and at the top of the files. It only removes standalone imports though. It does not remove CommonModule if that is the only import.
fe2420f
to
ac195e4
Compare
|
This PR was merged into the repository by commit 17adf0f. |
jessicajaniuk
added a commit
that referenced
this pull request
Nov 13, 2023
) This update removes imports from component decorators and at the top of the files. It only removes standalone imports though. It does not remove CommonModule if that is the only import. PR Close #52763
prasantht96
added a commit
to prasantht96/angular
that referenced
this pull request
Nov 14, 2023
commit 15a825c Author: Sasidharan SD <sasidharaninfotech@gmail.com> Date: Sat Nov 11 02:50:27 2023 +0530 docs: fix provideRouter typo (angular#52798) PR Close angular#52798 commit 4d868a3 Author: Dmitriy Mishchenko <ripatrip@gmail.com> Date: Sat Nov 11 09:52:36 2023 +0200 docs(docs-infra): a11y improvement suggestion Property Binding tutorial (angular#52807) angular#52639 issue fix suggestion PR Close angular#52807 commit 282a49c Author: Sasidharan SD <sasidharaninfotech@gmail.com> Date: Sun Nov 12 10:22:29 2023 +0530 docs: fix ngComponentOutlet api reference link (angular#52829) PR Close angular#52829 commit 2d98735 Author: oliv37 <olivier.boisse@laposte.net> Date: Sun Nov 12 18:32:05 2023 +0100 docs: improve filter results example (angular#52838) PR Close angular#52838 commit 42805e3 Author: Jessica Janiuk <jessicajaniuk@google.com> Date: Mon Nov 13 15:26:29 2023 -0500 fix(migrations): Add support for bound versions of NgIfElse and NgIfThenElse (angular#52869) This ensures the bound version of NgIfElse and NgIfThenElse work properly with the migration. fixes: angular#52842 PR Close angular#52869 commit 26e980d Author: marktechson <2554588+MarkTechson@users.noreply.github.com> Date: Mon Nov 13 15:56:19 2023 -0600 docs: remove live event from the home page (angular#52878) PR Close angular#52878 commit 0485eb8 Author: Joey Perrott <josephperrott@gmail.com> Date: Mon Nov 13 21:07:12 2023 +0000 ci: correct label for bazel-saucelabs job (angular#52873) Update the label to the correct schema PR Close angular#52873 commit 9e2c3bb Author: Etienne FRANK <etienne.frank@bit.admin.ch> Date: Fri Nov 10 20:16:32 2023 +0100 docs(forms): replace fb with formBuilder (angular#52795) Shorten variable names isn't a good practice. To avoid spreading it, we removed it from Angular's documentation. PR Close angular#52795 commit 726530a Author: Andrew Scott <atscott@google.com> Date: Wed Oct 18 09:54:56 2023 -0700 feat(router): Allow `onSameUrlNavigation: 'ignore'` in `navigateByUrl` (angular#52265) There are cases where the application's default behavior is 'reload' and a certain navigation might want to override this to be `ignore` instead. This commit allows `onSameUrlNavigation` in the `router.navigateByUrl` to be `ignore` where it was previously restricted to only `reload`. PR Close angular#52265 commit c5ead61 Author: Andrew Scott <atscott@google.com> Date: Mon Oct 23 07:22:30 2023 -0700 refactor(core): Move booleans in LContainer to flags slot (angular#52338) There are now 2 booleans in the LContainer so this commit moves them to a shared FLAGS slot like the LView. PR Close angular#52338 commit da616ee Author: Andrew Scott <atscott@google.com> Date: Thu Nov 2 13:02:35 2023 -0700 test(core): Ensure signals can be read after view creation during change detection (angular#52495) These tests ensure signals can be read in a template after embedded views are created in the middle of template execution of an update pass. The embedded view templates are executed in create mode in the middle of the component template being executed in update mode. This behavior was found to not work correctly in past implementations of the reactive template consumers. PR Close angular#52495 commit 0e7b1da Author: Jessica Janiuk <jessicajaniuk@google.com> Date: Mon Nov 13 12:10:13 2023 -0500 fix(migrations): Fixes issue with multiple if elses with same template (angular#52863) This should fix the issue where if the same ng-template is used with multiple if / else statements, it replaces all usages properly. fixes: angular#52854 PR Close angular#52863 commit 9135dba Author: Matthieu Riegler <kyro38@gmail.com> Date: Mon Nov 13 17:10:40 2023 +0100 refactor(animations): `EnvironmentProviders` for `provideAnimationsAsync` (angular#52862) This will prevent devs from using these providers in at a component level. PR Close angular#52862 commit 5ee11a7 Author: Matthieu Riegler <kyro38@gmail.com> Date: Tue Nov 7 09:01:20 2023 +0100 fix(animations): prevent the AsyncAnimationRenderer from calling the delegate when there is no element. (angular#52570) This happens when `issueAnimationCommand` is invoked fixes angular#52538 PR Close angular#52570 commit cf86ae5 Author: Matthieu Riegler <kyro38@gmail.com> Date: Mon Nov 13 00:23:02 2023 +0100 fix(http): Use the response `content-type` to set the blob `type`. (angular#52840) When downloading a PDF with the fetch client, the blob had no content. It couldn't be displayed in an iframe. This commit fixes this. Relate to: https://stackoverflow.com/questions/77470626/possible-bug-in-httpclient-when-using-the-blob-data-type PR Close angular#52840 commit 6aef0f6 Author: AleksanderBodurri <alexbodurri1117@gmail.com> Date: Fri Nov 10 02:22:35 2023 -0500 fix(core): handle non-container environment injector cases (angular#52774) Previously we had logic for a special case where a root injector in standalone apps would skip the import paths calculation step for the `getEnvironmentInjectorProviders` function. This commit intends to fix this for two other cases, namely: - When an injector is created by a route (via the `providers` field and lazy loading). - When an injector is manually created and attached to the injector tree It does this by assuming that any environment injector it cannot find a provider imports container for was created without one, and simply returns the raw provider records without the import paths calculation. PR Close angular#52774 commit f51ce68 Author: Sylvain DEDIEU <dedieu.sylvain38@gmail.com> Date: Fri Nov 10 08:21:04 2023 +0100 docs: update readme links to target angular.dev documentation (angular#52772) Change the angular.io links to target the new angular.dev website Changed the angular logo PR Close angular#52772 commit 181e4f3 Author: Sam Edwards <sam.g.edwards@warwick.ac.uk> Date: Fri Nov 10 17:27:52 2023 +0000 docs: correct component name on Managing Dynamic Data on angular.dev website (angular#52792) PR Close angular#52792 commit da97bbc Author: Jessica Janiuk <jessicajaniuk@google.com> Date: Fri Nov 10 15:11:37 2023 -0500 fix(migrations): passed in paths will be respected in nx workspaces (angular#52796) This fixes a bug where if you have multiple tsconfig files, the migration would not find anything to migrate at the passed in path. fixes: angular#52787 PR Close angular#52796 commit 17adf0f Author: Jessica Janiuk <jessicajaniuk@google.com> Date: Thu Nov 9 17:58:10 2023 -0500 fix(migrations): Add support for removing imports post migration (angular#52763) This update removes imports from component decorators and at the top of the files. It only removes standalone imports though. It does not remove CommonModule if that is the only import. PR Close angular#52763 commit 3cf18bb Author: AleksanderBodurri <alexbodurri1117@gmail.com> Date: Fri Nov 10 12:23:19 2023 -0500 fix(devtools): check for all new DI debug APIs before trying to determine resolution path providers (angular#52791) Previously, some versions of Angular 16.1.x that had 3/4 of the new DI debug APIs would enter a code path that required them to have access to the 4th. Now DevTools checks for the existence of all 4 explicitly before going down this code path. PR Close angular#52791 commit 70fe5e6 Author: Miles Malerba <mmalerba@google.com> Date: Wed Nov 8 10:50:12 2023 -0800 refactor(compiler): Handle trailing spaces in ICU placeholders (angular#52698) In some cases ICU expression placeholders may have trailing spaces that need to be trimmed when matching the placeholder to its corresponding text binding. PR Close angular#52698 commit 2c3b6c6 Author: Miles Malerba <mmalerba@google.com> Date: Tue Nov 7 21:46:56 2023 -0800 refactor(compiler): Fix some issues with i18n expressions in ICUs (angular#52698) We were previously counting the i18n expression index and deciding when to apply i18n expressions based on the i18n context. These should be done based on the i18n block instead. PR Close angular#52698 commit 0864dbe Author: Miles Malerba <mmalerba@google.com> Date: Tue Nov 7 17:27:12 2023 -0800 refactor(compiler): Change how ICUs are ingested (angular#52698) The previous commit added support for interpolated text in ICUs, but it made the assumption that the interpolation would be a single variable read expression. To properly support all kinds of interpolation expressions, this commit refactors how ICUs are ingested to allow us to re-use the same logic we use for bound text outside of ICUs. To accomplish this, the `IcuOp` creation op has been removed in favor of a pair of ops: `IcuStartOp` and `IcuEndOp`, that mark the beginning and end of the ICU. Now, instead of inserting an `IcuUpdateOp` in the update IR, we call `ingestBoundText` and use the presence of the surrounding `IcuStartOp` and `IcuEndOp` to match the interpolation with the ICU. PR Close angular#52698 commit 3a0ac32 Author: Miles Malerba <mmalerba@google.com> Date: Tue Nov 7 14:28:47 2023 -0800 refactor(compiler): Support expressions inside ICUs (angular#52698) Previously ICUs were assumed to only generate a single i18n expression per ICU. However, it is possible for ICUs to contain text interpolations which requires additional expressions. This commit adds support for multiple expressions per ICU. PR Close angular#52698 commit ef6999f Author: Miles Malerba <mmalerba@google.com> Date: Tue Nov 7 13:26:29 2023 -0800 refactor(compiler): Support element tags inside ICUs (angular#52698) ICUs that contain element tags need extra parameters for the i18n message. These are in addition to the element slot params that are already added to the parent i18n block's params. In this commit we add a new phase to fill in these placeholders. PR Close angular#52698 commit 50a06fa Author: Miles Malerba <mmalerba@google.com> Date: Mon Nov 6 15:39:14 2023 -0800 refactor(compiler): More consistent sorting of i18n params (angular#52698) Previously the template pipeline sorted i18n message params before adding the sub-message placeholders. Now its sorts after all placeholders are added. Both the template pipeline and TemplateDefinitionBuilder previously failed to sort the post-processing params. They both now sort these as well. This is safe to change in TemplateDefinitionBuilder, as it does not change anything about the functionality, it simply ensures that params map in the output has the keys ordered in a way that can be easily reproduced in the template pipeline. PR Close angular#52698 commit 5ee935e Author: Doug Parker <dgp1130@users.noreply.github.com> Date: Tue Nov 7 14:41:23 2023 -0800 release: bump DevTools version to 1.0.8 (angular#52759) PR Close angular#52759
prasantht96
added a commit
to prasantht96/angular
that referenced
this pull request
Nov 14, 2023
commit 15a825c Author: Sasidharan SD <sasidharaninfotech@gmail.com> Date: Sat Nov 11 02:50:27 2023 +0530 docs: fix provideRouter typo (angular#52798) PR Close angular#52798 commit 4d868a3 Author: Dmitriy Mishchenko <ripatrip@gmail.com> Date: Sat Nov 11 09:52:36 2023 +0200 docs(docs-infra): a11y improvement suggestion Property Binding tutorial (angular#52807) angular#52639 issue fix suggestion PR Close angular#52807 commit 282a49c Author: Sasidharan SD <sasidharaninfotech@gmail.com> Date: Sun Nov 12 10:22:29 2023 +0530 docs: fix ngComponentOutlet api reference link (angular#52829) PR Close angular#52829 commit 2d98735 Author: oliv37 <olivier.boisse@laposte.net> Date: Sun Nov 12 18:32:05 2023 +0100 docs: improve filter results example (angular#52838) PR Close angular#52838 commit 42805e3 Author: Jessica Janiuk <jessicajaniuk@google.com> Date: Mon Nov 13 15:26:29 2023 -0500 fix(migrations): Add support for bound versions of NgIfElse and NgIfThenElse (angular#52869) This ensures the bound version of NgIfElse and NgIfThenElse work properly with the migration. fixes: angular#52842 PR Close angular#52869 commit 26e980d Author: marktechson <2554588+MarkTechson@users.noreply.github.com> Date: Mon Nov 13 15:56:19 2023 -0600 docs: remove live event from the home page (angular#52878) PR Close angular#52878 commit 0485eb8 Author: Joey Perrott <josephperrott@gmail.com> Date: Mon Nov 13 21:07:12 2023 +0000 ci: correct label for bazel-saucelabs job (angular#52873) Update the label to the correct schema PR Close angular#52873 commit 9e2c3bb Author: Etienne FRANK <etienne.frank@bit.admin.ch> Date: Fri Nov 10 20:16:32 2023 +0100 docs(forms): replace fb with formBuilder (angular#52795) Shorten variable names isn't a good practice. To avoid spreading it, we removed it from Angular's documentation. PR Close angular#52795 commit 726530a Author: Andrew Scott <atscott@google.com> Date: Wed Oct 18 09:54:56 2023 -0700 feat(router): Allow `onSameUrlNavigation: 'ignore'` in `navigateByUrl` (angular#52265) There are cases where the application's default behavior is 'reload' and a certain navigation might want to override this to be `ignore` instead. This commit allows `onSameUrlNavigation` in the `router.navigateByUrl` to be `ignore` where it was previously restricted to only `reload`. PR Close angular#52265 commit c5ead61 Author: Andrew Scott <atscott@google.com> Date: Mon Oct 23 07:22:30 2023 -0700 refactor(core): Move booleans in LContainer to flags slot (angular#52338) There are now 2 booleans in the LContainer so this commit moves them to a shared FLAGS slot like the LView. PR Close angular#52338 commit da616ee Author: Andrew Scott <atscott@google.com> Date: Thu Nov 2 13:02:35 2023 -0700 test(core): Ensure signals can be read after view creation during change detection (angular#52495) These tests ensure signals can be read in a template after embedded views are created in the middle of template execution of an update pass. The embedded view templates are executed in create mode in the middle of the component template being executed in update mode. This behavior was found to not work correctly in past implementations of the reactive template consumers. PR Close angular#52495 commit 0e7b1da Author: Jessica Janiuk <jessicajaniuk@google.com> Date: Mon Nov 13 12:10:13 2023 -0500 fix(migrations): Fixes issue with multiple if elses with same template (angular#52863) This should fix the issue where if the same ng-template is used with multiple if / else statements, it replaces all usages properly. fixes: angular#52854 PR Close angular#52863 commit 9135dba Author: Matthieu Riegler <kyro38@gmail.com> Date: Mon Nov 13 17:10:40 2023 +0100 refactor(animations): `EnvironmentProviders` for `provideAnimationsAsync` (angular#52862) This will prevent devs from using these providers in at a component level. PR Close angular#52862 commit 5ee11a7 Author: Matthieu Riegler <kyro38@gmail.com> Date: Tue Nov 7 09:01:20 2023 +0100 fix(animations): prevent the AsyncAnimationRenderer from calling the delegate when there is no element. (angular#52570) This happens when `issueAnimationCommand` is invoked fixes angular#52538 PR Close angular#52570 commit cf86ae5 Author: Matthieu Riegler <kyro38@gmail.com> Date: Mon Nov 13 00:23:02 2023 +0100 fix(http): Use the response `content-type` to set the blob `type`. (angular#52840) When downloading a PDF with the fetch client, the blob had no content. It couldn't be displayed in an iframe. This commit fixes this. Relate to: https://stackoverflow.com/questions/77470626/possible-bug-in-httpclient-when-using-the-blob-data-type PR Close angular#52840 commit 6aef0f6 Author: AleksanderBodurri <alexbodurri1117@gmail.com> Date: Fri Nov 10 02:22:35 2023 -0500 fix(core): handle non-container environment injector cases (angular#52774) Previously we had logic for a special case where a root injector in standalone apps would skip the import paths calculation step for the `getEnvironmentInjectorProviders` function. This commit intends to fix this for two other cases, namely: - When an injector is created by a route (via the `providers` field and lazy loading). - When an injector is manually created and attached to the injector tree It does this by assuming that any environment injector it cannot find a provider imports container for was created without one, and simply returns the raw provider records without the import paths calculation. PR Close angular#52774 commit f51ce68 Author: Sylvain DEDIEU <dedieu.sylvain38@gmail.com> Date: Fri Nov 10 08:21:04 2023 +0100 docs: update readme links to target angular.dev documentation (angular#52772) Change the angular.io links to target the new angular.dev website Changed the angular logo PR Close angular#52772 commit 181e4f3 Author: Sam Edwards <sam.g.edwards@warwick.ac.uk> Date: Fri Nov 10 17:27:52 2023 +0000 docs: correct component name on Managing Dynamic Data on angular.dev website (angular#52792) PR Close angular#52792 commit da97bbc Author: Jessica Janiuk <jessicajaniuk@google.com> Date: Fri Nov 10 15:11:37 2023 -0500 fix(migrations): passed in paths will be respected in nx workspaces (angular#52796) This fixes a bug where if you have multiple tsconfig files, the migration would not find anything to migrate at the passed in path. fixes: angular#52787 PR Close angular#52796 commit 17adf0f Author: Jessica Janiuk <jessicajaniuk@google.com> Date: Thu Nov 9 17:58:10 2023 -0500 fix(migrations): Add support for removing imports post migration (angular#52763) This update removes imports from component decorators and at the top of the files. It only removes standalone imports though. It does not remove CommonModule if that is the only import. PR Close angular#52763 commit 3cf18bb Author: AleksanderBodurri <alexbodurri1117@gmail.com> Date: Fri Nov 10 12:23:19 2023 -0500 fix(devtools): check for all new DI debug APIs before trying to determine resolution path providers (angular#52791) Previously, some versions of Angular 16.1.x that had 3/4 of the new DI debug APIs would enter a code path that required them to have access to the 4th. Now DevTools checks for the existence of all 4 explicitly before going down this code path. PR Close angular#52791 commit 70fe5e6 Author: Miles Malerba <mmalerba@google.com> Date: Wed Nov 8 10:50:12 2023 -0800 refactor(compiler): Handle trailing spaces in ICU placeholders (angular#52698) In some cases ICU expression placeholders may have trailing spaces that need to be trimmed when matching the placeholder to its corresponding text binding. PR Close angular#52698 commit 2c3b6c6 Author: Miles Malerba <mmalerba@google.com> Date: Tue Nov 7 21:46:56 2023 -0800 refactor(compiler): Fix some issues with i18n expressions in ICUs (angular#52698) We were previously counting the i18n expression index and deciding when to apply i18n expressions based on the i18n context. These should be done based on the i18n block instead. PR Close angular#52698 commit 0864dbe Author: Miles Malerba <mmalerba@google.com> Date: Tue Nov 7 17:27:12 2023 -0800 refactor(compiler): Change how ICUs are ingested (angular#52698) The previous commit added support for interpolated text in ICUs, but it made the assumption that the interpolation would be a single variable read expression. To properly support all kinds of interpolation expressions, this commit refactors how ICUs are ingested to allow us to re-use the same logic we use for bound text outside of ICUs. To accomplish this, the `IcuOp` creation op has been removed in favor of a pair of ops: `IcuStartOp` and `IcuEndOp`, that mark the beginning and end of the ICU. Now, instead of inserting an `IcuUpdateOp` in the update IR, we call `ingestBoundText` and use the presence of the surrounding `IcuStartOp` and `IcuEndOp` to match the interpolation with the ICU. PR Close angular#52698 commit 3a0ac32 Author: Miles Malerba <mmalerba@google.com> Date: Tue Nov 7 14:28:47 2023 -0800 refactor(compiler): Support expressions inside ICUs (angular#52698) Previously ICUs were assumed to only generate a single i18n expression per ICU. However, it is possible for ICUs to contain text interpolations which requires additional expressions. This commit adds support for multiple expressions per ICU. PR Close angular#52698 commit ef6999f Author: Miles Malerba <mmalerba@google.com> Date: Tue Nov 7 13:26:29 2023 -0800 refactor(compiler): Support element tags inside ICUs (angular#52698) ICUs that contain element tags need extra parameters for the i18n message. These are in addition to the element slot params that are already added to the parent i18n block's params. In this commit we add a new phase to fill in these placeholders. PR Close angular#52698 commit 50a06fa Author: Miles Malerba <mmalerba@google.com> Date: Mon Nov 6 15:39:14 2023 -0800 refactor(compiler): More consistent sorting of i18n params (angular#52698) Previously the template pipeline sorted i18n message params before adding the sub-message placeholders. Now its sorts after all placeholders are added. Both the template pipeline and TemplateDefinitionBuilder previously failed to sort the post-processing params. They both now sort these as well. This is safe to change in TemplateDefinitionBuilder, as it does not change anything about the functionality, it simply ensures that params map in the output has the keys ordered in a way that can be easily reproduced in the template pipeline. PR Close angular#52698 commit 5ee935e Author: Doug Parker <dgp1130@users.noreply.github.com> Date: Tue Nov 7 14:41:23 2023 -0800 release: bump DevTools version to 1.0.8 (angular#52759) PR Close angular#52759 commit 94096c6 Author: Kristiyan Kostadinov <crisbeto@abv.bg> Date: Thu Nov 9 11:53:01 2023 +0100 feat(core): support TypeScript 5.3 (angular#52572) Updates the repo to support TypeScript 5.3 and resolve any issues. Fixes include: * Updating usages of TS compiler APIs to match their new signatures. * In TS 5.3 negative numbers are represented as `PrefixUnaryExpression` instead of `NumericExpression`. These changes update all usages to account for it since passing a negative number into the old APIs results in a runtime error. PR Close angular#52572 commit beb18fb Author: Jessica Janiuk <jessicajaniuk@google.com> Date: Thu Nov 9 15:51:10 2023 -0500 refactor(migrations): code clean up and add comments on exported functions (angular#52755) This cleans up a bit of code to make maintenance easier. It also adds comments for all the exported methods so they are clear to anyone in the future. PR Close angular#52755 commit f84cce0 Author: Jessica Janiuk <jessicajaniuk@google.com> Date: Thu Nov 9 15:20:18 2023 -0500 docs: release notes for the v17.0.2 release commit 6c8776f Author: Pawel Kozlowski <pkozlowski.opensource@gmail.com> Date: Thu Nov 9 18:18:43 2023 +0100 fix(core): limit rate of markers invocations (angular#52742) This PR assures that the performance markers are invoked only once for a given feature. Closes angular#52524 PR Close angular#52742 commit 154f286 Author: Sasidharan SD <sasidharaninfotech@gmail.com> Date: Thu Nov 9 13:41:50 2023 +0530 docs: add extended diagnostic NG8109 (angular#52721) PR Close angular#52721 commit 71a4d6a Author: Mikita Himpel <gimpelllll@gmail.com> Date: Thu Nov 9 13:27:53 2023 +0100 docs: fix programmatic-rendering example component name (angular#52731) PR Close angular#52731 commit c5e4424 Author: Nelson Gutierrez <nelson.gutierrez.vega@gmail.com> Date: Wed Nov 8 20:07:11 2023 -0600 docs: add missing backtick on title (angular#52711) PR Close angular#52711 commit cb5c6fc Author: Patrick Hyatt <patrickhyatt@duck.com> Date: Wed Nov 8 21:29:02 2023 -0500 docs: correct typescript type inference link (angular#52714) PR Close angular#52714 commit 5935f91 Author: Balaji <88931771+Rajendran-Balaji@users.noreply.github.com> Date: Thu Nov 9 09:20:38 2023 +0530 docs: updating incorrect link in Class Binding page (angular#52715) PR Close angular#52715 commit 867161f Author: Mikhail Filin <mikhailf.codes@gmail.com> Date: Thu Nov 9 21:47:17 2023 +0400 docs: remove broken link pill in dynamic component page (angular#52744) PR Close angular#52744 commit f212736 Author: Jeevan Mahesha <csejeevanm@gmail.com> Date: Thu Nov 9 23:28:07 2023 +0530 docs: removed the broken link (angular#52743) PR Close angular#52743 commit 029edea Author: Tom Wilkinson <tbondwilkinson@gmail.com> Date: Tue Nov 7 16:08:04 2023 -0600 refactor(common): Update packages/common/src/navigation/platform_navigation.ts (angular#52363) Co-authored-by: Andrew Scott <atscott01@gmail.com> PR Close angular#52363 commit 27f5eed Author: Thomas Wilkinson <twilkinson@google.com> Date: Tue Oct 24 20:01:57 2023 -0500 refactor(common): Add fake implementation of PlatformNavigation. (angular#52363) This implementation does most, but not all, of the things the native Navigation API does. Also adds a spec that tests all the currently supported behaviors. PR Close angular#52363 commit 77770c6 Author: Thomas Wilkinson <twilkinson@google.com> Date: Tue Oct 24 17:57:07 2023 -0500 refactor(common): Add a new platform_navigation that provides the Navigation API. (angular#52363) This allows using the Navigation API in Angular packages like Router. PR Close angular#52363 commit 55d2c42 Author: Andrew Kushnir <akushnir@google.com> Date: Wed Nov 8 15:57:42 2023 -0800 refactor(core): delay applying component metadata until it's needed in tests (angular#52708) When a component contains `@defer` blocks, Angular compiler generates the code to apply component metadata (from the `@Component` decorator) after resolving all dynamic dependencies. Currently, this function is invoked eagerly at runtime, which causes dynamic imports to be kicked off earlier than expected. With the change in this commit, Angular will start resolving async metadata when it becomes necessary during testing. PR Close angular#52708 commit 8c8ff63 Author: Vadim Makeev <hi@pepelsbey.dev> Date: Tue Nov 7 12:15:24 2023 +0100 docs: make homepade example accessible (angular#52578) PR Close angular#52578 commit 645447d Author: Kristiyan Kostadinov <crisbeto@abv.bg> Date: Thu Nov 9 14:25:03 2023 +0100 fix(compiler-cli): incorrect inferred type of for loop implicit variables (angular#52732) Fixes that all implicit variables in `@for` loops were inferred to be numbers, even though most are actually boolean. Note that I also had to work around a weird TypeScript behavior in `tsDeclareVariable` where usually we declare variables in the following format: ``` var _t1: <type> = null!; ``` This works in most cases, but if the type is a `boolean`, TypeScript infers the variable as `never`, instead of `boolean`. I've worked around it by adding an `as boolean` to the initializer. Fixes angular#52730. PR Close angular#52732 commit 8a87e62 Author: cexbrayat <cedric@ninja-squad.com> Date: Wed Nov 8 17:28:31 2023 +0100 fix(compiler-cli): add interpolatedSignalNotInvoked to diagnostics (angular#52687) This template diagnostic has been introduced in 8eef694 but was not enabled, as it was not added to `ALL_DIAGNOSTIC_FACTORIES`. PR Close angular#52687 commit ea8c9b6 Author: Pawel Kozlowski <pkozlowski.opensource@gmail.com> Date: Wed Nov 8 21:48:20 2023 +0100 fix(core): properly update collection with repeated keys in @for (angular#52697) This change fixes a bug in the new list reconcilation algorithm that could lead to an infinite loop in certain situations. More specifically, it adjusts the internal MultiMap implementation such that an entry returned from the .get call is the same entry (for an identical key) removed by the .delete call. The existing logic of the MultiMap was leading to a situation where one view was requested and attached to LContainer, but a very different view was removed from the MultiMap. This was leaving an attached LView in a collection that was supposed to hold only detached views. Closes angular#52524 PR Close angular#52697 commit cc68b0e Author: cexbrayat <cedric@ninja-squad.com> Date: Thu Nov 9 11:06:40 2023 +0100 fix(core): error code in image performance warning (angular#52727) The warnings link to https://angular.io/errors/NG2965 which is a 404 The proper error page is https://angular.io/errors/NG0913 PR Close angular#52727 commit b1cc092 Author: Sylvain DEDIEU <dedieu.sylvain38@gmail.com> Date: Thu Oct 5 06:54:13 2023 +0200 docs(docs-infra): improve decorator deprecated property display in documentation (angular#52041) Add the deprecated-api-item class on decorator-overview option code if deprecated. Add deprecated label on decorator-overview short description if deprecated. Add Add deprecated label on decorator option table header if option is deprecated. PR Close angular#52041 commit 1d3d33f Author: Andrew Scott <atscott@google.com> Date: Mon Nov 6 11:58:43 2023 -0800 docs: fix broken http link (angular#52541) fixes angular#52542 PR Close angular#52541 commit ab99171 Author: Andrew Scott <atscott@google.com> Date: Mon Nov 6 11:53:19 2023 -0800 docs: fix broken DI link on roadmap (angular#52541) fixes angular#52539 PR Close angular#52541 commit 56b96f6 Author: Sam Verschueren <sam.verschueren@gmail.com> Date: Tue Nov 7 14:39:17 2023 +0100 docs: fix LCP element link (angular#52580) PR Close angular#52580 commit 68f89b0 Author: Sasidharan SD <sasidharaninfotech@gmail.com> Date: Tue Nov 7 21:10:43 2023 +0530 docs: fix angular compatability version (angular#52585) PR Close angular#52585 commit 3d98a44 Author: Sasidharan SD <sasidharaninfotech@gmail.com> Date: Tue Nov 7 21:26:16 2023 +0530 docs: fix incorrect tag reference (angular#52586) PR Close angular#52586 commit 9dff1fe Author: Sasidharan SD <sasidharaninfotech@gmail.com> Date: Tue Nov 7 21:32:48 2023 +0530 docs: fix repetetive text (angular#52587) PR Close angular#52587 commit 2ee1b5c Author: Sasidharan SD <sasidharaninfotech@gmail.com> Date: Tue Nov 7 21:58:51 2023 +0530 docs: fix cli command redirection (angular#52589) PR Close angular#52589 commit 3153892 Author: Sasidharan SD <sasidharaninfotech@gmail.com> Date: Tue Nov 7 22:05:32 2023 +0530 docs: fix prefetching typo issue (angular#52590) PR Close angular#52590 commit 0ffa228 Author: Sasidharan SD <sasidharaninfotech@gmail.com> Date: Wed Nov 8 03:55:53 2023 +0530 docs: add missing backtick (angular#52607) PR Close angular#52607 commit 01f9b57 Author: Ryth-cs <49680490+Ryth-cs@users.noreply.github.com> Date: Tue Nov 7 23:01:19 2023 +0000 docs: correct reactive-forms typo (angular#52608) PR Close angular#52608 commit b25153a Author: Raghav Kanwal <raghav.kanwal@gmail.com> Date: Wed Nov 8 02:23:30 2023 -0800 docs: update typo in Guide/Testing (angular#52619) PR Close angular#52619 commit fc8f521 Author: technbuzz <samiullah.khan.1989@gmail.com> Date: Wed Nov 8 18:40:05 2023 +0400 docs: fix typo in component output guide (angular#52673) We should use @output rathar than @input decorator for output events. This comments fixes the typo by replacing Input with Output PR Close angular#52673 commit 8fee560 Author: Marianna Maglio <mariannabellamia@gmail.com> Date: Wed Nov 8 16:42:18 2023 +0100 docs: fix typos in tutorials/learn-angular (angular#52677) PR Close angular#52677 commit 4526335 Author: Sasidharan SD <sasidharaninfotech@gmail.com> Date: Thu Nov 9 00:19:01 2023 +0530 docs: fix developer preview link (angular#52693) PR Close angular#52693 commit 9cac4ee Author: Jessica Janiuk <jessicajaniuk@google.com> Date: Wed Nov 8 19:19:43 2023 +0000 docs: release notes for the v17.0.1 release commit 291ba38 Author: Matthieu Riegler <kyro38@gmail.com> Date: Thu Nov 2 20:25:19 2023 +0100 fix(http): Don't override the backend when using the InMemoryWebAPI (angular#52425) When using `withFetch`, the `PRIMARY_HTTP_BACKEND` token is set. The InMemory Backend services will also set that token. This means that providers order will matter and the latest on the list will be the one instantiated PR Close angular#52425 commit 12f979d Author: Jessica Janiuk <jessicajaniuk@google.com> Date: Tue Nov 7 14:20:37 2023 -0500 fix(migrations): Add support for ng-templates with i18n attributes (angular#52597) This makes sure that i18n attributes are preserved on ng-templates being removed during the migration. fixes: angular#52517 PR Close angular#52597 commit abdbdf7 Author: Andrew Scott <atscott@google.com> Date: Wed Nov 8 09:33:53 2023 -0800 refactor(language-service): Add flag to allow disabling block syntax parsing (angular#52691) This commit adds a flag to the language service config options to disable block parsing in the compiler. PR Close angular#52691 commit 49cbe43 Author: Kristiyan Kostadinov <crisbeto@abv.bg> Date: Wed Nov 8 17:29:06 2023 +0100 refactor(compiler): add flag to disable block syntax in language service (angular#52683) Adds the private `_enableBlockSyntax` flag that can be used by the language service to disable blocks on apps that aren't on Angular v17. PR Close angular#52683 commit 9b92d7d Author: Kristiyan Kostadinov <crisbeto@abv.bg> Date: Wed Nov 8 18:03:55 2023 +0100 fix(docs-infra): fix menu icon size (angular#52689) Fixes that the hamburger icon was too small, because the top nav is using the wrong kind of button. Switching it to the right one would require more refactoring so I went with the simpler approach for now. PR Close angular#52689 commit c745ca2 Author: cexbrayat <cedric@ninja-squad.com> Date: Wed Nov 8 14:50:00 2023 +0100 refactor(core): sanitize reactivity tests (angular#52632) It was intriguing to see a double `fixture.detectChanges()` introduced by 38c9f08 It turns out this is not needed. PR Close angular#52632 commit abc225b Author: Swami <anilsanapathi9@gmail.com> Date: Sat Nov 4 01:04:08 2023 +0530 docs: typo fix (angular#52511) PR Close angular#52511 commit 33da677 Author: Andrew Scott <atscott@google.com> Date: Fri Oct 27 15:49:14 2023 -0700 refactor(core): Remove RootViewRef<T> because it is the same as ViewRef<T> (angular#52430) `RootViewRef<T>` extends `ViewRef<T>` and overrides 3 methods with behavior that is identical to `ViewRef<T>`. This commit removes `RootViewRef<T>` because it is not needed. PR Close angular#52430 commit 289a178 Author: Matthieu Riegler <kyro38@gmail.com> Date: Sun Aug 20 22:42:12 2023 +0200 docs: add v17 versions support (angular#51443) * Node 16 support is dropped per angular/angular-cli#25675 * TS 5.2 is supported per angular#51334 * TS 5.1 and lower support is dropped by angular#51792 PR Close angular#51443 commit 62bd8c5 Author: Lucas <lucasluizss@live.com> Date: Tue Nov 7 21:52:44 2023 +0000 docs: updating information about polyfills (angular#52519) PR Close angular#52519 commit 8592585 Author: Andrew Scott <atscott@google.com> Date: Thu Oct 26 16:56:06 2023 -0700 test(core): Add test to ensure writing to signals in afterRender hooks throws error (angular#52475) We do not yet handle running change detection again if `afterRender` hooks write to signals. PR Close angular#52475 commit b9e2893 Author: Jessica Janiuk <jessicajaniuk@google.com> Date: Tue Nov 7 11:59:55 2023 -0500 fix(migrations): Switches to multiple passes to fix several reported bugs (angular#52592) Rather than migrate all in one pass, this now migrates in a separate pass per control flow item plus one for templates at the end. This resolves issues with multiple control flow items on a single element as well as making sure ng-templates are fully migrated before being moved to new locations. fixes: angular#52518 fixes: angular#52516 fixes: angular#52513 PR Close angular#52592 commit 3f2501e Author: Alex Rickabaugh <alx+alxhub@alxandria.net> Date: Wed Nov 8 07:12:45 2023 -0800 build: bump in-memory-web-api to v17 (angular#52676) This commit updates the in-memory-web-api package versions from v16 -> v17. PR Close angular#52676 commit 1e87ce2 Author: Pawel Kozlowski <pkozlowski.opensource@gmail.com> Date: Wed Nov 8 16:13:52 2023 +0100 docs: add the v17 blog post link to the changelog (angular#52675) This commit adds the short link 'http://goo.gle/angular-v17' to the project changelog. PR Close angular#52675 commit 33ae659 Author: Pawel Kozlowski <pkozlowski.opensource@gmail.com> Date: Wed Nov 8 15:13:05 2023 +0100 build: update aio to 17.0.0 (angular#52635) This commit updates the Angular version for AIO and its examples to 17.0.0 PR Close angular#52635 commit 5ebb361 Author: Pawel Kozlowski <pkozlowski.opensource@gmail.com> Date: Wed Nov 8 13:29:08 2023 +0100 docs: release notes for the v17.0.0 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
action: merge
The PR is ready for merge by the caretaker
area: migrations
Issues related to `ng update` migrations
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update removes imports from component decorators and at the top of the files. It also checks to make sure CommonModule is not being used and removes that too.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?