Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fixed typos #52297

Closed
wants to merge 1 commit into from
Closed

docs: fixed typos #52297

wants to merge 1 commit into from

Conversation

thapasusheel
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe: Typos fixed in multiple files

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

foward > forward
dependening > depending
executue > execute
sampel > sample
fils > file

AndrewKushnir
AndrewKushnir reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thapasusheel thanks for improving Angular docs!

Could you please update the commit message (using git commit --amend) to start with docs: ?

@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews area: docs target: patch This PR is targeted for the next patch release labels Oct 24, 2023
@ngbot ngbot bot modified the milestone: Backlog Oct 24, 2023
@thapasusheel
Copy link
Contributor Author

@AndrewKushnir I have updated commit message as you have mention. Could you please review it?

@AndrewKushnir AndrewKushnir changed the title Fixed typos docs: fixed typos Oct 25, 2023
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 25, 2023
@AndrewKushnir
Copy link
Contributor

Caretaker note: docs-only (low risk) change, no extra reviews are required. This PR is ready for merge.

@dylhunn dylhunn removed the request for review from JiaLiPassion October 25, 2023 23:38
@pullapprove pullapprove bot requested a review from JiaLiPassion October 25, 2023 23:38
@dylhunn
Copy link
Contributor

dylhunn commented Oct 25, 2023

This PR was merged into the repository by commit 31c7bc1.

dylhunn pushed a commit that referenced this pull request Oct 25, 2023
@thapasusheel @dylhunn
docs: fixed typos (#52297)
57630c3 
PR Close #52297
dylhunn pushed a commit that referenced this pull request Oct 25, 2023
@thapasusheel @dylhunn
docs: fixed typos (#52297)
38b4602 
PR Close #52297
@dylhunn dylhunn closed this in 31c7bc1 Oct 25, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 25, 2023
tbondwilkinson pushed a commit to tbondwilkinson/angular that referenced this pull request Dec 6, 2023
@thapasusheel @tbondwilkinson
docs: fixed typos (angular#52297)
d2ee582 
PR Close angular#52297
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@thapasusheel @ChellappanRajan
docs: fixed typos (angular#52297)
61237f7 
PR Close angular#52297
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@JiaLiPassion JiaLiPassion Awaiting requested review from JiaLiPassion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@thapasusheel @AndrewKushnir @dylhunn