Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: migrate snapshot publishing from CircleCI to GHA #51957

Closed
wants to merge 1 commit into from
Closed

ci: migrate snapshot publishing from CircleCI to GHA #51957

wants to merge 1 commit into from

Conversation

josephperrott
Copy link
Member

No description provided.

@josephperrott josephperrott added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Sep 29, 2023
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Sep 29, 2023
@ngbot ngbot bot added this to the Backlog milestone Sep 29, 2023
devversion
devversion reviewed Oct 5, 2023
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to remove the CircleCI code as well. Also do we know something about the runner size if we perform a new build here?

@josephperrott
Copy link
Member Author

I did some testing and didn't find any real difference between different runner sizes.

@josephperrott josephperrott force-pushed the publish-snapshots branch 3 times, most recently from 3309be4 to 03eb07a Compare October 5, 2023 16:32
@josephperrott
ci: migrate snapshot publishing from CircleCI to GHA
c1b64c3 
Migrate the snapshot publishing from CircleCI to GHA
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 5, 2023
@atscott
Copy link
Contributor

atscott commented Oct 5, 2023

This PR was merged into the repository by commit e12a102.

@atscott atscott closed this in e12a102 Oct 5, 2023
atscott pushed a commit that referenced this pull request Oct 5, 2023
@josephperrott @atscott
ci: migrate snapshot publishing from CircleCI to GHA (#51957)
2a10050 
Migrate the snapshot publishing from CircleCI to GHA

PR Close #51957
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 6, 2023
@josephperrott josephperrott deleted the publish-snapshots branch December 21, 2023 14:22
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@josephperrott @ChellappanRajan
ci: migrate snapshot publishing from CircleCI to GHA (angular#51957)
6394f18 
Migrate the snapshot publishing from CircleCI to GHA

PR Close angular#51957
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@josephperrott @atscott @devversion