Architecture overview #2528
Merged
Architecture overview #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowone
reviewed
Mar 27, 2021
|
Wouldn't this be a suitable document to be placed on the rustpython web page? The docs repo looks like it would be good candidate. |
|
@DimitrisJim I agree. Would you please review it? |
DimitrisJim
reviewed
Aug 4, 2021
architecture/architecture.md
Outdated
| Some things to note: | ||
|
|
||
| - The CLI is defined in `src/lib.rs@run` | ||
| - The interface and helper for the REPL are defined in this package, but the actual REPL can be found in `vm/rustyline.rs` |
There was a problem hiding this comment.
it's vm/src/readline.rs (now, at least).
DimitrisJim
force-pushed
the
2524-architecture-overview
branch
from
c038228
to
36db236
Compare
…t in top level readme.
DimitrisJim
force-pushed
the
2524-architecture-overview
branch
from
36db236
to
f95d73f
Compare
DimitrisJim
approved these changes
Jun 11, 2023
fanninpm
reviewed
Jun 11, 2023
|
|
||
| A high-level overview of the workings of RustPython is visible in the figure below, showing how Python source files are interpreted. | ||
|
|
||
|  |
There was a problem hiding this comment.
You might want to consider rewriting this diagram in Mermaid.
There was a problem hiding this comment.
that's wild. +1 but can probably leave this for a later point.
Co-authored-by: fanninpm <fanninpm@miamioh.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the architecture document as proposed by #2524.
This PR serves as a place for discussion regarding updates, suggestions and improvements 😃.