Skip to content

gh-111177: Add timezone awareness checks to datetime module#111193

Closed
jakob-keller wants to merge 3 commits intopython:mainfrom
jakob-keller:datetime-awareness-checks
Closed

gh-111177: Add timezone awareness checks to datetime module#111193
jakob-keller wants to merge 3 commits intopython:mainfrom
jakob-keller:datetime-awareness-checks

Conversation

@jakob-keller
Copy link

@jakob-keller jakob-keller commented Oct 22, 2023

@ghost
Copy link

ghost commented Oct 22, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@jakob-keller
Copy link
Author

The draft does not include any changes to the C implementation of the datetime module. Anyone willing to help me out?

@sobolevn
Copy link
Member

@jakob-keller I can :)

@jakob-keller
Copy link
Author

@jakob-keller I can :)

That would be awesome! Anyway I can facilitate this?

@sobolevn
Copy link
Member

Done! Feel free to ping me for any questions :)

@sobolevn
Copy link
Member

Great work, @jakob-keller! Thanks a lot for your PR and proposal. I will leave this to @pganssle to review, because I am obviously biased now.

@jakob-keller jakob-keller marked this pull request as ready for review October 23, 2023 08:50
@jakob-keller jakob-keller marked this pull request as draft October 30, 2023 13:42
@jakob-keller jakob-keller deleted the datetime-awareness-checks branch December 14, 2023 14:06
@jakob-keller
Copy link
Author

Thanks again @sobolevn for your work on this! Unfortunately, there does not appear to be substantial support for the proposal and I have closed the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

datetime module should provide timezone awareness checks

2 participants