C#: Handle netstandard references in standalone extraction
#14545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
changed the title
netstandard.library.ref from the referencesnetstandard references in standalone extraction
tamasvajk
force-pushed
the
standalone/remove-netstandard.library.ref
branch
from
63f94a0
to
3f1e145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles
netstandardtarget frameworks. When multiple frameworks are targeted then the assemblies get deduplicated by name. Netstandard packages contain anetstandard.dllassembly, which conflicts with other variants.The first DCA experiment shows significant improvement on
DewGaming/PokemonDatabase, where it removes 266810 compilation errors.The second DCA experiment shows that this could be further improved. netcoreapp2.0 seems to also reference netstandard2.0, so there are cases when both nuget packages are expected to be fetched.