Add additional shell script examples for the new Job output environment variables#22276
Add additional shell script examples for the new Job output environment variables#22276SimonDarksideJ wants to merge 4 commits into
Conversation
…r each shell language
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
github-actions
Bot
added
the
triage
|
@SimonDarksideJ Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
cmwilson21
added
content
|
All in the day as an MVP :S |
This comment was marked as spam.
This comment was marked as spam.
lucascosti
left a comment
lucascosti
left a comment
There was a problem hiding this comment.
👋 @SimonDarksideJ, thanks a lot for this PR!
🤔 This one's a bit of a tough situation. The use-case for the reusable that you've edited is to show the use of the YAML syntax for the jobs.<job_id>.outputs key, and not really for the scripting to set the environment variable that the key uses (we currently have that documented in "Workflow commands for GitHub Actions ."). We currently have the Bash and powershell examples there.
I do realize that we don't explain this at all for this jobs.<job_id>.outputs example 😅 . Instead of repeating the examples with different scripting, how about we add a short explanation of setting the environment variable and link to the relevant section of the workflow commands article instead?
This comment was marked as spam.
This comment was marked as spam.
|
@SimonDarksideJ I'll be closing this PR due to inactivity - but if you would like to work on this further, we're happy to reopen this PR 💛 |
|
To be honest @nguyenalex836 I had given up on this PR as it did not seem desired, even though it was to address an issue I came across in the docs. |
|
I'm sorry to hear that, @SimonDarksideJ! Let us know if you'd like to reopen this PR - we're happy to do so 💛 |
6 participants
Why:
The documentation about the new Output variables for sharing data between jobs was inaccurate as it only handled the default Ubuntu "Bash" version of the commands.
What's being changed (if available, include any code snippets, screenshots, or gifs):
This updates Job output variables to denote the different versions used for each shell language, kept original Bash, added Powershell and Python
Check off the following: