update go tools version from v0.11.1 to v0.13.0 #14314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This was referenced Sep 26, 2023
mbg
approved these changes
Sep 26, 2023
Member
mbg
left a comment
mbg
left a comment
There was a problem hiding this comment.
Thanks again for opening this PR! ✨ The changes look reasonable to me and I am happy for us to bump the version of these dependencies to the latest version, even though it is not required to fix the problem you ran into, as discussed in that issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tooling on the module imports isn't working as expected in my automated CI, i.e. x.y.z go mod versions don't seem to be supported, only x.y (the new support for 1.21.1 is triggering this for me).
This project is laid out a bit differently with the vendoring than most projects I've used, so someone should double-check my work, but I think I updated the tools package correctly.