New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update language display names #14282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in the text and titles look good, but you are right to ask about imports -- those should not change.
docs/codeql/codeql-language-guides/basic-query-for-cpp-code.rst
Outdated
Show resolved
Hide resolved
|
@adityasharad @henrymercer Thanks for the review! One thing - should all the Java articles in here https://codeql.github.com/docs/codeql-language-guides/codeql-for-java/ be updated to mention Kotlin throughout? I noticed some already did, but some didn't, so wasn't sure if that was on purpose... |
That seems reasonable to me but @igfoo would know for sure. |
I think that would be OK. There are some places where Kotlin is a bit different, and some Kotlin examples would be good (notably the Javadoc page), but I think that that's covered by the beta warning. |
|
Thanks @igfoo @henrymercer! I'll update the rest of the Java articles to also mention Kotlin in the headers/content, will do that tomorrow! |
...odeql/codeql-language-guides/abstract-syntax-tree-classes-for-working-with-java-programs.rst
Outdated
Show resolved
Hide resolved
|
@henrymercer @igfoo @adityasharad Thanks again and apologies for the delay! I now updated all the Java language guides to include Kotlin in the titles and in some of the content. I also added the Kotlin beta note in most of the articles to make it clear. If all looks good, if one of you can approve then I'll go ahead and merge this so it is in |
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Co-authored-by: Henry Mercer <henry.mercer@me.com>
For issue: https://github.com/github/docs-content/issues/12061
Overall release: https://github.com/github/docs-content/issues/11174
I've updated the mentions of Java and Javascript to also include Kotlin and TypeScript, respectively. I have also updated the language identifiers in a few places to reflect the new keywords.
I didn't touch anything related to the VS Code extension right now, as I think changes for that are still unknown/in the works.
Questions for reviewers:
import javashould now sayimport java-kotlin? For now I changed them to say that but let me know and I can change them back