Update newton_raphson.py#8869
Conversation
for more information, see https://pre-commit.ci
|
@cclauss , plz review this. |
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
for more information, see https://pre-commit.ci
|
while executing this test Also precision is initially defined in function argument (precision: float = 10**-10) then why we should make a test case with different precisions?? |
Because the caller might choose to change the default. Why are there no tests that change the default precision? |
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
|
How does |
|
@QuantumNovice your review of these changes please. |
|
This should precision <= 0 as python will set the float to zero which is a valid answer.
The |
|
This should be an input variable as it does not generate correct solution for arbitrary function. |
|
@QuantumNovice What would be a valid test to replace |
|
Why does this test not pass? |
|
Closing due to lack of fixes in response to code review. We need to clear out our backlog of PRs as much as possible before Hacktoberfest, and this PR still has failing tests. |


Describe your change:
Fixes #8863
Checklist: