Swift: flow through keypath optional components#14014
Merged
rdmarsh2 merged 5 commits intogithub:mainfrom Aug 22, 2023
Merged
Conversation
rdmarsh2
changed the title
MathiasVP
reviewed
Aug 22, 2023
| c.isSingleton(any(Content::ArrayContent ac)) | ||
| ) | ||
| or | ||
| // Store throug |
Contributor
There was a problem hiding this comment.
I think this sentence needs a bit of love 😂
geoffw0
previously approved these changes
Aug 22, 2023
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
LGTM too. There are some analysis time regressions on the DCA run, though they look more like wobbles than anything related to this PR.
Contributor
Indeed, there's a couple of stage-timing changes. But since nothing is reflected in the end-to-end it's probably just wobble. |
MathiasVP
approved these changes
Aug 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.