Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPP: Add Delete[] calls to the IR. #14038

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

alexet
Copy link
Contributor

@alexet alexet commented Aug 23, 2023

The models delete calls as call to the operator delete in the IR

Notes:

  • Arguments other than the pointer are ignored (the call will just have 1 arg for the call even if it needs 2-4).
  • No handling of the destructor.
  • No side affect is added like we have for `new
  • No checking for null (kind-of OK, it's unspecified whether the deallocator is called for null, clang and gcc check for null but msvc passes it along)

The new test results are all true positives.

MRVA finds some FPs though

@github-actions github-actions bot added the C++ label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant