ReDoS: limit concretize to strings of at most length 100 #14027
Merged
+2
∄1�71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that Swift has also added a couple of queries that use the shared regex library now. So you may want to include Swift in the list of DCA experiments. |
@MathiasVP: does this look OK? https://github.com/github/codeql-dca-main/tree/data/erik-krogh/pr-14027-25e4f2__nightly__code-scanning/reports |
|
It does. Thanks! |
yoff
approved these changes
Aug 24, 2023
|
New evals still look good (see backrefs). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a performance problem in a Python project, and seems to have no change in results🤞
Evaluations: Python, Ruby, Java, JavaScript.
Only a single lost result in the Ruby evaluation, but I think we can live with that.
Otherwise seemingly no change, just some DCA noise.