New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C#: Compile against the reference assemblies in the standalone extractor (if possible) #13970
base: main
Are you sure you want to change the base?
C#: Compile against the reference assemblies in the standalone extractor (if possible) #13970
Conversation
6aafc51
to
d1b0267
Compare
|
Uh. I am trying to replace the .NET runtime dll's with the corresponding references assemblies, but the DB-CHECK fails: https://github.com/github/semmle-code/actions/runs/5876713182/job/15935436224 |
Regarding Maybe we should change the scheme and have Regarding: This is odd. Is it possible that Roslyn is not returning the correct type kind? This is what we have in the extractor: case TypeKind.Class: return Kinds.TypeKind.CLASS;
case TypeKind.Struct:
return ((INamedTypeSymbol)Symbol).IsTupleType && !constructUnderlyingTupleType
? Kinds.TypeKind.TUPLE
: Kinds.TypeKind.STRUCT;At the same time, we do have type.IsTupleType ? TupleType.Create(cx, type) : (IEntity)NamedType.Create(cx, type); |
|
@tamasvajk : Thank you very much for the pointers! They are extremely helpful!!! |
No description provided.