Ruby: Improve desugaring of for loops
#13937
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would desugar
forloopsinto
However, when the iteration variable
xis used after the loop (as a captured variable inside the loop), the rewrite only becomes correct whenxeither has a prior assignment, or if we add anilinitialization.This PR therefor improves the desugaring by adding a conditional initial assignment:
The rewrite also works when there are multiple iteration variables:
gets desugared into