Python: MaD on externals #13935
Open
Python: MaD on externals #13935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For this test, we can simply use the convention, that a file called `[ql-file-stem].ext.yml` will be used as data extensions exactly for the test represented by `ql-file`.
For these tests, we cannot use the same mechanism, as we want the data extensions to be available for both tests. Instead, we create a ql-pack for the test directory and point to the data entensions from there. This makes the extensions available for all tests in the directory.
yoff
force-pushed
the
python/mad-on-externals
branch
from
98c9425
to
dbc6014
Compare
RasmusWL
requested changes
Aug 11, 2023
There was a problem hiding this comment.
I don't think the approach of changing codeql-workspace.yml for the sake of testing MaD in extension files is good. I can think of two alternative ways to fix this:
- convince core team to allow a
<foo>.ext.ymlto apply to all tests within a folder, instead of just<foo>.ql - merge the content of
InlineTaintTest.qlandNormalDataflowTest.qlto one file (such asAllTests.ql)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites our tests of MaD via flow summaries, such that they use data extensions instead of CVS-row-predicates. This serves two purposes:
We also switch to the agreed naming convention for data extensions. Since we do not use data extensions yet, the switch only involves the obligatory empty extension.