Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Support Argument[this] and parameters of bodiless interface methods in framework mode metadata extraction #13823

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kaeluka
Copy link
Contributor

@kaeluka kaeluka commented Jul 26, 2023

  1. There was an unintended limitation to only consider ExplicitParameterNodes in framework mode, but skipped the this parameter. This PR fixes the problem. I'll add a test case to the currently open test PR once this is merged.
  2. In framework mode we also skipped the parameters of interface methods without bodies — this PR fixes the problem as well. However, I'm not 100% sure this is the best way to fix this (it might have unintended consequences) and would appreciate thoughts from the Java team. We could, for instance, try to keep our changes to the DataFlow::ParameterNode types local to the automodel code (if needed).

@github-actions github-actions bot added the Java label Jul 26, 2023
@kaeluka kaeluka changed the title Java: Support Argument[this] in framework mode metadata extraction Java: Support Argument[this] and parameters of bodiless interface methods in framework mode metadata extraction Jul 27, 2023
@kaeluka kaeluka force-pushed the kaeluka/support-argument-this-in-frameworkmode-metadata-extraction branch from f56aff4 to b5862ae Compare July 27, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant