Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataflow: MergePathGraph3 signature fix #13822

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Dataflow: MergePathGraph3 signature fix #13822

wants to merge 2 commits into from

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Jul 26, 2023 •
edited

MergePathGraph3::PathGraph wasn't compatible with MergePathGraph3::PathNode. This created a problem when making a MergePathGraph3 of a MergePathGraph3, for example.

@owen-mc owen-mc requested review from a team as code owners July 26, 2023 15:10
@owen-mc owen-mc added the no-change-note-required This PR does not need a change note label Jul 26, 2023
@owen-mc
Copy link
Contributor Author

owen-mc commented Jul 26, 2023 •
edited

I'll rebase this when #13824 is merged to fix the failing Go tests.

@owen-mc
Fix DataFlow::MergePathGraph3
e0cc337 
Need to get the signatures correct.
@owen-mc
Sync files
9b2b58a
@owen-mc owen-mc force-pushed the dataflow/mergepathgraph3-signature-fix branch from f5584ad to 9b2b58a Compare July 26, 2023 20:48
@owen-mc owen-mc mentioned this pull request Jul 27, 2023
Open
aschackmull
aschackmull approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschackmull aschackmull aschackmull approved these changes

@github/codeql-swift codeql-swift Awaiting requested review from github/codeql-swift github/codeql-swift is a code owner

@github/codeql-ruby codeql-ruby Awaiting requested review from github/codeql-ruby github/codeql-ruby is a code owner

@github/codeql-python codeql-python Awaiting requested review from github/codeql-python github/codeql-python is a code owner

@github/codeql-go codeql-go Awaiting requested review from github/codeql-go github/codeql-go is a code owner

@github/codeql-csharp codeql-csharp Awaiting requested review from github/codeql-csharp github/codeql-csharp is a code owner

@github/codeql-c-analysis codeql-c-analysis Awaiting requested review from github/codeql-c-analysis github/codeql-c-analysis is a code owner

@michaelnebel michaelnebel Awaiting requested review from michaelnebel

Assignees
No one assigned
Labels
C# C++ Go Java no-change-note-required This PR does not need a change note Python Ruby Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@owen-mc @aschackmull